-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: search request amount made on page arrival #486
Conversation
f3b59d8
to
d9f1e16
Compare
f27181f
to
2a0ce46
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything worked fine for me while testing - I built the package with yarn build and used a project from the cloud.
The only issue I can see is that on start or refresh, it first shows the page with "It seems like Meilisearch isn’t running, did you forget to start it? - (Don’t forget to set an API Key if you want one)", then "Sorry mate, no results matching your request
I expect it to show directly the results with a loading state.
But this should not block this PR; it can be tackled in another PR, and we can decide whether to release it like this or not in Meilisearch 1.6.1.
I'm opening an issue in this repo.
EDIT: link of the issue
Pull Request
What does this PR do?
MeilisearchClientContext
for maintainability (instead of passing down 2 clients to the components)useEffect
)App
file are now wrapped inside auseCallback
App
file)PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!