Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove extra config #18

Merged
merged 9 commits into from
Jun 20, 2024
Merged

chore: remove extra config #18

merged 9 commits into from
Jun 20, 2024

Conversation

Strift
Copy link
Contributor

@Strift Strift commented Jun 19, 2024

Partially addresses #9

The goal of this PR is to remove the code that was inherited from the mini-dashboard fork, but isn't strictly necessary for the demo purpose.

For simplicity, removing cypress & storybook will be done in separate PRs

@Strift Strift marked this pull request as draft June 19, 2024 15:11
@Strift Strift marked this pull request as ready for review June 19, 2024 15:18
@Strift Strift requested review from mdubus and Kerollmops June 19, 2024 15:18
@Strift
Copy link
Contributor Author

Strift commented Jun 19, 2024

Hi, @Kerollmops @mdubus 👋 I'm requesting a review to ensure I'm not removing something that would break the app. Thanks for your help!

Copy link
Member

@Kerollmops Kerollmops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect to me! Hoping the CI is happy now!

Copy link
Member

@mdubus mdubus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✨🦕 🌻

Nice work 👏 🤩

@Strift Strift merged commit 0ce78ca into main Jun 20, 2024
1 check passed
@Strift Strift deleted the chore/remove-extra-config branch June 20, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants