Errors - Add variant for invalid_filter/invalid_sort when related settings are empty

[gmourier]

Summary

Add a variant for invalid_filter and invalid_sort errors when filterablesAttributes / sortablesAttributes are empty.

[brunoocasali]

I'm not sure why, but this works: https://docs.meilisearch.com/reference/api/error_codes.html#invalid-filter not https://docs.meilisearch.com/reference/api/error_codes.html#invalid_filter.

Any thoughts @guimachiavelli @bidoubiwa ?

[gmourier]

Good spot @brunoocasali! May need to update the whole specification then 🥷 At least the link leads to the errors page.

[bidoubiwa]

The errors page story is an old one built on an ancient and questionable script. See meilisearch/documentation#1299
But good new, it is being updated by @maryamsulemani97 meilisearch/documentation#1503

Once that PR is merged there shouldn't be any anchor problems and we'll be able to search for error codes in the search bar of the documentation

[gmourier]

As long as the anchors work and the routes returned by the binary do not fall on a 404, it is all good on our side.

Please, let us know if we need to make a change on our end. On the other side, it could be managed with redirections on the documentation site 😇

[guimachiavelli]

The Errors page was until recently completely separate from the regular docs website. While all our docs are written in markdown, that specific page was generated from a yaml file as described by @bidoubiwa. We scrapped that a few weeks ago and moved the Errors page completely inside vuepress. The transition was a glorified copypaste of yaml content into an md file; it also moved docs.meilisearch.com/errors into docs.meilisearch.com/api/error_codes.html. meilisearch/documentation#1503 will further improve the page (and possibly move it again).

The anchor link formatting is related to this transition. Vuepress automatically turns spaces into -, not _. docs.meilisearch.com/errors#invalid_filter only worked because the Errors page was outside vuepress. Now that the Errors page is being parsed as markdown, all anchor links will use -.

We are already redirecting regular links (https://docs.meilisearch.com/errors) to the new page (https://docs.meilisearch.com/reference/api/errors), but I'm unsure our redirects allow us to do the same for anchor links. Even if it is possible, it would probably require a lot of effort for relatively little gain (as @gmourier says, users are still brought to the correct page).

[gmourier]

Thanks, @guimachiavelli for the information! It should be easy to change the links on the core side if it's not possible to have a redirection on the documentation side that would lead to the right anchor.

The advantage of redirection is that we are all more independent.

It's not a big problem, just let me know if the redirection is possible when we have time to explore this topic. Then we'll see. 🚀

[brunoocasali]

🔥 🚒

[guimachiavelli]

Variant error messages in line with our other warnings. LGTM! 🍰

[gmourier]

Merging it since the last commit was a minor change and the spec has been approved just before. Thanks, team!