This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
Add specification about both new logs experimental features #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irevoire
added
Ready For Review
This was referenced Feb 14, 2024
macraig
approved these changes
Feb 14, 2024
gmourier
suggested changes
Feb 15, 2024
| @@ -260,6 +262,8 @@ This property allows us to gather essential information to better understand on | |||
| | infos.with_configuration_file | `true` if the instance is launched with a configuration file, otherwise `false` | `false` | | |||
| | infos.task_queue_webhook | `true` if the instance is launched with a task queue webhook, otherwise `false` | `false` | | |||
| | infos.experimental_enable_metrics | `true` if `--experimental-enable-metrics`/`MEILI_EXPERIMENTAL_ENABLE_METRICS` is specified at launch, otherwise `false` | `false` | | |||
| | infos.experimental_logs_mode | `human` or `json` depending on the value specified. | `human` | | |||
There was a problem hiding this comment.
Is infos.experimental_logs_mode both affected by the CLI and an API call when settings up the stream route?
Co-authored-by: Guillaume Mourier <guillaume@meilisearch.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
See https://www.notion.so/meilisearch/Improve-debug-velocity-c756d428dd4b4716b353acde68a958cd?d=befaf62375a44c23a15e3ffe792e9dc5#66c2b0b87a1c4030a600269180c3dd81
Changes