Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

Add gpu_enabled to telemetry #267

Merged
merged 2 commits into from
Mar 11, 2024
Merged

Add gpu_enabled to telemetry #267

merged 2 commits into from
Mar 11, 2024

Conversation

dureuill
Copy link
Contributor

🤖 API Diff Put the link of the GitHub comment generated by bump.sh if generated; Apply the OpenApi label


Summary

cf title


Changes

cf title

Out Of Scope

N/A


Attention To Reviewers

N/A


Misc

  • Update telemetry datapoints (if needed; Apply the Telemetry label)

@dureuill dureuill added the Telemetry Update the telemetry collect. label Feb 26, 2024
@dureuill dureuill requested a review from macraig February 26, 2024 13:26
@dureuill dureuill changed the base branch from main to release-v1.7.0 February 26, 2024 13:26
Copy link
Member

@irevoire irevoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a second place where you’re supposed to add it.

Try to search for infos.experimental_reduce_indexing_memory_usage for example and it should appear in two places

@dureuill
Copy link
Contributor Author

nice catch @irevoire , I don't cope well with DRY violations 👀

btw funny, the infos.experimental_reduce_indexing_memory_usage was also appearing only once, had to search for infos.experimental_enable_metrics instead.

I fixed that as well...

@irevoire
Copy link
Member

😬
Yeah, I feel like that’s a part of the specification we should either simplify or get rid of.
Plus, the documentation already maintains a single list of all the telemetry we send: https://www.meilisearch.com/docs/learn/what_is_meilisearch/telemetry#exhaustive-list-of-all-collected-data

@macraig macraig mentioned this pull request Mar 11, 2024
4 tasks
@macraig macraig merged commit b11f5c9 into release-v1.7.0 Mar 11, 2024
2 checks passed
@macraig macraig deleted the gpu_enabled branch March 11, 2024 19:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Telemetry Update the telemetry collect.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants