Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

Distinct Attribute #32

Merged
merged 10 commits into from
Apr 29, 2021
Merged

Distinct Attribute #32

merged 10 commits into from
Apr 29, 2021

Conversation

gmourier
Copy link
Member

Initialize specification for Distinct attribute.

@gmourier gmourier added the Draft Feature specification is in draft state. Summary and Motivation parts need to be written. label Apr 16, 2021
@gmourier gmourier changed the title DISTINCT Attribute Distinct Attribute Apr 16, 2021
@gmourier gmourier added In Progress Feature specification is in elaboration. Important changes can still occurs in the specification. and removed Draft Feature specification is in draft state. Summary and Motivation parts need to be written. labels Apr 20, 2021
@gmourier gmourier marked this pull request as ready for review April 20, 2021 11:07
@gmourier gmourier added the Ready For Review Feature specification must be reviewed. label Apr 20, 2021
@gmourier gmourier force-pushed the distinct-attribute branch from b443423 to ae50741 Compare April 21, 2021 09:52
@gmourier
Copy link
Member Author

Added some details about ElasticSearch

@gmourier gmourier removed the In Progress Feature specification is in elaboration. Important changes can still occurs in the specification. label Apr 21, 2021
@curquiza curquiza mentioned this pull request Apr 22, 2021
Closed
curquiza
curquiza approved these changes Apr 26, 2021
View reviewed changes
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gmourier 😄

MarinPostma
MarinPostma approved these changes Apr 27, 2021
View reviewed changes
Copy link
Contributor

@MarinPostma MarinPostma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great spec! thanks 🚀

bidoubiwa
bidoubiwa suggested changes Apr 28, 2021
View reviewed changes
text/0032-distinct-attribute.md Outdated Show resolved Hide resolved
text/0032-distinct-attribute.md Outdated Show resolved Hide resolved
text/0032-distinct-attribute.md Show resolved Hide resolved
text/0032-distinct-attribute.md Show resolved Hide resolved
text/0032-distinct-attribute.md Show resolved Hide resolved
bidoubiwa
bidoubiwa approved these changes Apr 29, 2021
View reviewed changes
Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 🔥 🔥

@gmourier gmourier merged commit 574f0c6 into main Apr 29, 2021
@gmourier gmourier deleted the distinct-attribute branch April 29, 2021 15:14
@gmourier gmourier added Ready To Be Implemented Feature specification is ready to be implemented. and removed Ready For Review Feature specification must be reviewed. labels Apr 29, 2021
@gmourier gmourier added Implemented Feature specification has been implemented. and removed Ready To Be Implemented Feature specification is ready to be implemented. labels Jun 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bidoubiwa bidoubiwa bidoubiwa approved these changes

@MarinPostma MarinPostma MarinPostma approved these changes

@curquiza curquiza curquiza approved these changes

Assignees
No one assigned
Labels
Implemented Feature specification has been implemented. Q2:2021 v0.21
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gmourier @curquiza @MarinPostma @bidoubiwa