Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass strapi client agent to meilisearch-js #455

Merged
merged 3 commits into from
Jul 4, 2022

Conversation

bidoubiwa
Copy link
Contributor

Spread the strapi agent to meilisearch-js

@bidoubiwa bidoubiwa added the skip-changelog The PR will not appear in the release changelogs label Jul 4, 2022
@bidoubiwa bidoubiwa requested review from brunoocasali and mdubus July 4, 2022 15:28
Base automatically changed from fix_breaking_changes_v0.28.0 to bump-meilisearch-v0.28.0 July 4, 2022 16:33
@bidoubiwa bidoubiwa merged commit 6cf66e6 into bump-meilisearch-v0.28.0 Jul 4, 2022
@bidoubiwa bidoubiwa deleted the add_client_headers branch July 4, 2022 16:33
new Meilisearch({
...config,
clientAgents: [
`Meilisearch strapi-plugin-meilisearch ${packageJson.version}`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bidoubiwa I suggest you follow: meilisearch/integration-guides#150 (comment) because Guillaume amplitude graphs can be impacted!

@bidoubiwa bidoubiwa changed the title Add strapi agent to client agents Pass client agent to meilisearch-js Jul 6, 2022
@bidoubiwa bidoubiwa added enhancement New feature or request and removed skip-changelog The PR will not appear in the release changelogs labels Jul 6, 2022
@bidoubiwa bidoubiwa changed the title Pass client agent to meilisearch-js Pass strapi client agent to meilisearch-js Jul 6, 2022
meili-bors bot added a commit that referenced this pull request Jul 12, 2022
457: Update version for the next release (v0.7.0) r=bidoubiwa a=bidoubiwa

Content of the release:

This version makes this package compatible with Meilisearch v0.28.0 🎉
Check out the changelog of [Meilisearch v0.28.0](https://github.com/meilisearch/meilisearch/releases/tag/v0.28.0) for more information on the changes.


## 💥 Breaking changes

- This release is **only** compatible with the latest version of [Meilisearch v0.28.0](https://github.com/meilisearch/meilisearch/releases/tag/v0.28.0)

## 🚀 Enhancements

- Pass strapi client agent to meilisearch-js #455

Analytics is enabled by default in the server, but you can disable them by following [this guide](https://docs.meilisearch.com/learn/what_is_meilisearch/telemetry.html#how-to-disable-data-collection)
Also, of course, every analytics data we collect are ANONYMOUS [read the guide for more information](https://docs.meilisearch.com/learn/what_is_meilisearch/telemetry.html).

Thanks again to `@bidoubiwa` ! 🎉

Co-authored-by: Charlotte Vermandel <charlottevermandel@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants