-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass strapi client agent to meilisearch-js #455
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bidoubiwa
added
the
skip-changelog
The PR will not appear in the release changelogs
label
Jul 4, 2022
mdubus
approved these changes
Jul 4, 2022
Base automatically changed from
fix_breaking_changes_v0.28.0
to
bump-meilisearch-v0.28.0
July 4, 2022 16:33
brunoocasali
reviewed
Jul 4, 2022
new Meilisearch({ | ||
...config, | ||
clientAgents: [ | ||
`Meilisearch strapi-plugin-meilisearch ${packageJson.version}`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bidoubiwa I suggest you follow: meilisearch/integration-guides#150 (comment) because Guillaume amplitude graphs can be impacted!
20 tasks
bidoubiwa
changed the title
Add strapi agent to client agents
Pass client agent to meilisearch-js
Jul 6, 2022
bidoubiwa
added
enhancement
New feature or request
and removed
skip-changelog
The PR will not appear in the release changelogs
labels
Jul 6, 2022
bidoubiwa
changed the title
Pass client agent to meilisearch-js
Pass strapi client agent to meilisearch-js
Jul 6, 2022
meili-bors bot
added a commit
that referenced
this pull request
Jul 12, 2022
457: Update version for the next release (v0.7.0) r=bidoubiwa a=bidoubiwa Content of the release: This version makes this package compatible with Meilisearch v0.28.0 🎉 Check out the changelog of [Meilisearch v0.28.0](https://github.com/meilisearch/meilisearch/releases/tag/v0.28.0) for more information on the changes. ## 💥 Breaking changes - This release is **only** compatible with the latest version of [Meilisearch v0.28.0](https://github.com/meilisearch/meilisearch/releases/tag/v0.28.0) ## 🚀 Enhancements - Pass strapi client agent to meilisearch-js #455 Analytics is enabled by default in the server, but you can disable them by following [this guide](https://docs.meilisearch.com/learn/what_is_meilisearch/telemetry.html#how-to-disable-data-collection) Also, of course, every analytics data we collect are ANONYMOUS [read the guide for more information](https://docs.meilisearch.com/learn/what_is_meilisearch/telemetry.html). Thanks again to `@bidoubiwa` ! 🎉 Co-authored-by: Charlotte Vermandel <charlottevermandel@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spread the strapi agent to meilisearch-js