Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused dependencies #60

Closed
wants to merge 1 commit into from

Conversation

lukeapage
Copy link
Contributor

I couldn't work out why these were present? but maybe there is a reason...

@meinaart
Copy link
Owner

meinaart commented Sep 8, 2019

I think these are needed for socket.io to behave correctly. Especially the uws one. I would need to do a manual test to see if it would still work.

@lukeapage
Copy link
Contributor Author

It appears to work fine on windows without uws
The documentation suggests uws is only required if the wsEngine property overrides the websocket type and I can't find anywhere in cypress-plugin-snapshots that does that: https://github.com/socketio/engine.io#methods-1

@meinaart meinaart closed this Feb 20, 2020
@meinaart
Copy link
Owner

Merged via #98.

@meinaart meinaart reopened this Feb 20, 2020
@meinaart meinaart closed this Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants