Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Drug Reference Maps #219

Closed
mogoodrich opened this issue Feb 17, 2023 · 5 comments · Fixed by #226
Closed

Add Support for Drug Reference Maps #219

mogoodrich opened this issue Feb 17, 2023 · 5 comments · Fixed by #226
Assignees

Comments

@mogoodrich
Copy link
Contributor

Drugs in OpenMRS can be mapped to reference terms in the same manner as Concepts (see Drug Reference Map in orders)

We should support this in Iniz as follows:

In the Drugs domain, support specifying mapping in the same was we do for concepts as described here:

https://github.com/mekomsolutions/openmrs-module-initializer/blob/master/readme/concepts.md (see "Mapping Headers" section... we will support the new recommended format "Mappings|SAME-AS" aod "Mappings|SAME-AS|Source" format)

@mks-d @ibacher @mseaton @rbuisson fyi... any thoughts? At PIH we need this and can likely build this out in the coming weeks.

@mks-d
Copy link
Member

mks-d commented Feb 18, 2023

Thanks @mogoodrich - I will let others comment in more details but if this is

  1. Useful to PIH
  2. Backward compatible (looks like it would be)
  3. Documented in the README(s)

then we are welcoming this suggested improvement. Depending on the timing this would make it in 2.5.0 or 2.6.0.

@ibacher
Copy link
Member

ibacher commented Feb 20, 2023

This seems like an excellent addition to me!

@mogoodrich
Copy link
Contributor Author

Yes, @mks-d all three of those things will be true, thanks!

@mseaton mseaton self-assigned this Mar 1, 2023
@mseaton
Copy link
Collaborator

mseaton commented Mar 2, 2023

I ran into a bit of a snag here. See https://issues.openmrs.org/browse/TRUNK-6164. Will need to discuss how to work around this in Initializer. @ibacher FYI

@mseaton
Copy link
Collaborator

mseaton commented Mar 2, 2023

I have a solution for this ready for review @ibacher . Unfortunately the PR is failing in Github Actions because it depends on the latest 2.3.x build, and OpenMRS CI is failing to build 2.3.x due to Bamboo issues. Once we resolve that, things should turn green.

@mseaton mseaton linked a pull request Mar 2, 2023 that will close this issue
Ruhanga added a commit to Ruhanga/openmrs-module-initializer that referenced this issue Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants