refactor: 💄 august #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since this commit: comfyanonymous/ComfyUI@9534f0f Input <-> widget is possible on booleans. Locally I edited it but forgot about it not being in comfy This commit is reversable since I'm not yet sure of all the impacts
The maths are still not correct I need to debug it in isolation
This was referenced Aug 9, 2023
Will allow to install missing deps/models from the endpoint: /mtb/status
Closed
should be ready to go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch from my custom
BOOLtype to the comfy'sBOOLEANone since now there is builtin support for convertible widgets (comfyanonymous/ComfyUI@9534f0f) - Still need more testing.Remove the Prores node and replace it with a more general ffmpeg streaming node.
Use PIL for GIF and not ffmpeg (better quality / filesize overall)
Improve Animation Builder's UX
Add a curve widget on the
Fit Numbernode to interpolate the value, if too complex, at least start with a preselection of easing methods (https://easings.net/):Add "F.pad" to
Transform Image:Fix the web install, I received many reports either through issues or DM about that. (cc https://github.com/melMass/comfy_mtb/discussions/42#discussioncomment-6600043)
Refactor which classes are in which file, some stuff are still messy