Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle case of missing .cmj when trying to inline external field #1067

Merged
merged 7 commits into from
Feb 19, 2024

Conversation

anmonteiro
Copy link
Member

@anmonteiro anmonteiro commented Feb 16, 2024

this is the melange part of the fix for #658.

  • Melange looks for some inlining information in the .cmj files for implementations. When compiling virtual libraries, .cmj files are deferred until a specific implementation has been selected, so they won't be available at this time
  • There's a more thorough explanation in the code about what the fix does.

fixes #658

TODO:

  • add a blackbox-test

@anmonteiro anmonteiro force-pushed the anmonteiro/fix-virtual-libs branch from f0fe036 to d5e7514 Compare February 17, 2024 04:07
@anmonteiro anmonteiro force-pushed the anmonteiro/fix-virtual-libs branch from d5e7514 to e4e99d3 Compare February 17, 2024 04:10
@anmonteiro anmonteiro merged commit b409141 into main Feb 19, 2024
4 checks passed
@anmonteiro anmonteiro deleted the anmonteiro/fix-virtual-libs branch February 19, 2024 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot use virtual modules without specify implementation library in libraries
2 participants