Dune action-plugin: don't read unnecessary file contents #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmonteiro
force-pushed
the
anmonteiro/dont-read-files
branch
from
1b27c86 to
3ed9ae0
Compare
In order to track dynamic dependencies we were: 1. reading each `*.d` file produced by `bsb_helper` 2. for each dependency in the `*.d` file, track it in dune by reading their file contents We can avoid reading files into memory altogether by calling the `read_directory_with_glob` function instead, which declares dependencies on those files without reading their contents.
anmonteiro
force-pushed
the
anmonteiro/dont-read-files
branch
from
3ed9ae0 to
25ff0c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to track dynamic dependencies we were:
*.dfile produced bybsb_helper*.dfile, track it in dune by readingtheir file contents
We can avoid reading files into memory altogether by calling the
read_directory_with_globfunction instead, which declares dependencieson those files without reading their contents.