feat: improve Js.Int and change some functions to pipe-last #966
Conversation
| @@ -9,7 +9,7 @@ var suites_0 = [ | |||
| return { | |||
| TAG: /* Eq */0, | |||
| _0: "1.23456e+5", | |||
| _1: (123456).toExponential() | |||
| _1: (123456).toExponential(undefined) | |||
There was a problem hiding this comment.
Interesting. This only happens when no labeled args are passed, right? Hopefully it doesn't have any impact on other JS apis 🤔
There was a problem hiding this comment.
yeah. I checked every function to make sure the undefined argument is not an issue.
In the case of Js.Date, for example, we need to keep separate functions, as the undefined argument can make the functions return NaN.
jscomp/runtime/js_int.ml
Outdated
| external toPrecisionWithPrecision : int -> digits:int -> string = "toPrecision" | ||
| [@@mel.send] | ||
| external toPrecision : ?digits:t -> string = "toPrecision" | ||
| [@@mel.send.pipe: t] | ||
| (** Formats an [int] using some fairly arbitrary rules | ||
|
|
||
| {b digits} specifies how many digits should appear in total. The |
There was a problem hiding this comment.
Maybe unrelated to the PR, but the part below is a bit unwarranted imo:
for Node it's 21. Why? Who knows
There was a problem hiding this comment.
I fixed this. It was pretty easy to check the accepted range by passing it 0:
| @@ -116,32 +78,16 @@ before the decimal point. | |||
| @raise RangeError if digits is not in the range accepted by this function (what do you mean "vague"?) | |||
|
|
|||
| {[ | |||
| (* prints "1.2e+8" *) | |||
There was a problem hiding this comment.
I can't comment on them, but there are some refs to toPrecisionWithPrecision that are now obsolete:
melange/jscomp/runtime/js_int.ml
Lines 72 to 76 in 564b968
anmonteiro
force-pushed
the
anmonteiro/improve-js-int
branch
from
564b968 to
087e985
Compare
Co-authored-by: Javier Chávarri <javier.chavarri@gmail.com>
No description provided.