Add Config

[SmsS4]

This pr is to solve #31

[Dentrax]

Thanks for this! @SmsS4

I tried to use NewWithConfigFile() function with goph.NewConn() but got open ~/.ssh/identity: no such file or directory error. Any ideas? 🤔

[SmsS4]

hmmmm this PRis for 1.5 years ago
I will check it tomorrow :)

[Dentrax]

Thanks for prompt reply! Also it'd be nice to add another function to return only Auth:

func GetAuth(host string) (goph.Auth, error) {
	auth, err := goph.Key(ssh_config.Get(host, "IdentityFile"), "")
	if err != nil {
		return nil, fmt.Errorf("get key: %w", err)
	}
	return auth, nil
}

[melbahja]

Hey thanks for the PR, can you please use return instead of log fatal.

[SmsS4]

I fixed your comments

[SmsS4]

Thanks for prompt reply! Also it'd be nice to add another function to return only Auth:

func GetAuth(host string) (goph.Auth, error) {
	auth, err := goph.Key(ssh_config.Get(host, "IdentityFile"), "")
	if err != nil {
		return nil, fmt.Errorf("get key: %w", err)
	}
	return auth, nil
}

I used your code in new commit
thanks

By default ssh_config.Get(host, "IdentityFile") returns ~/.ssh/identity so you have to set IdentityFile in ssh config.
for example:

Host vpn
	HostName 127.0.0.1
	User test
	IdentityFile /home/demol/.ssh/id_rsa

[melbahja]

Hey thanks for the update,

one more thing if you can use NewConn instead of New in case of custom port with fallback to 22.

v2 of this package I should add more configuration options suport

[Dentrax]

By default ssh_config.Get(host, "IdentityFile") returns ~/.ssh/identity so you have to set IdentityFile in ssh config.

I was wondering if it does make sense to return an error in case if IdentityFile is empty or equals to ssh_config.Default("IdentityFile")

Also you'd consider to remove leading and trailing "s, I just filed an issue for that: kevinburke/ssh_config#61

strings.Trim(ssh_config.Get(host, key), "\"")

[SmsS4]

I will update my fork and use NewConn instead of New (probably tomorrow or day after tomorrow
Thanks @melbahja

Hey thanks for the update,

one more thing if you can use NewConn instead of New in case of custom port with fallback to 22.

v2 of this package I should add more configuration options suport

[SmsS4]

By default ssh_config.Get(host, "IdentityFile") returns ~/.ssh/identity so you have to set IdentityFile in ssh config.

I was wondering if it does make sense to return an error in case if IdentityFile is empty or equals to ssh_config.Default("IdentityFile")

Also you'd consider to remove leading and trailing "s, I just filed an issue for that: kevinburke/ssh_config#61

strings.Trim(ssh_config.Get(host, key), "\"")

It's probably good idea to use ~/.ssh/id_rsa by default and not ~/.ssh/identity but I only return error if ~/.ssh/identity doesn't exists.
I will update this soon @Dentrax

[SmsS4]

@melbahja
I used NewConn instead of New with a little bit of refactoring

[melbahja]

I'll need a bit of time to test the changes. Thanks.

[mehrdad-khojastefar]

Can you review these changes ? this pr could really help us.

[melbahja]

The ssh_config lib has many issues like:

• can't find the default IdentityFile if not set in the config file.
• if your ~/.ssh/config or '/etc/ssh/ssh_config' file contains Include the lib Get will always returns empty values
• @Dentrax issue will still exists even with Trim bcz the fallbacks to not exists file ~/.ssh/identity, see: https://github.com/kevinburke/ssh_config/blob/974a52c2c04b3e24e189311ef9776b87153dd961/validators.go#L120

I think you should solve the ssh config problem outside of goph and just pass the hostname, port, and identity to it, and I don't think this is a good think to add it to v1 maybe in v2.