-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Table component to MUI #153
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introducing baseline changes to move Table component away from material-table and use MUITable. Code is not finalized and contains several open points to be addressed. BREAKING CHANGE: 🧨 Removed material-table direct dependency and all related dependencies ✅ Closes: 149
✅ Closes: 149
Aligned all existing features of the Table with new underlying engine. Added some cool features like internal memory for selection and sorting, pre-selection and pre-sorting allowed, stickyHeaders and table height. BREAKING CHANGE: 🧨 Changed signature for onPageSizeChange and onSortChange ✅ Closes: 149
✅ Closes: 149
✅ Closes: 149
Restored feature parity of global, row and selection actions in Table component ✅ Closes: 149
✅ Closes: 149
When table has no data by default a message is shown. User can provide custom empty state via 'emptyState' property ✅ Closes: 100
✅ Closes: 149
✅ Closes: 149
✅ Closes: 149
✅ Closes: 149
✅ Closes: 149
✅ Closes: 149
This was
linked to
issues
Oct 1, 2020
Closed
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains work to close #149, and also closes #88, closes #98 and closes #100.