Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not popup for google doc on microsoft edge #2175

Closed
hsunwenfang opened this issue Aug 26, 2024 · 2 comments · Fixed by #2176
Closed

Not popup for google doc on microsoft edge #2175

hsunwenfang opened this issue Aug 26, 2024 · 2 comments · Fixed by #2176

Comments

@hsunwenfang
Copy link

hsunwenfang commented Aug 26, 2024

Describe the bug
Not popup for google doc on microsoft edge

To Reproduce
Install and use on Edge

Expected behavior
Popup on Edge contents

Screenshots
If applicable, add screenshots to help explain your problem.

System details (OS, browser version, rikaikun version)

  • OS: MacOS Sonoma 14.6
  • Browser Version: Version 128.0.2739.42
  • rikaikun Version: 3.0.0

Additional context
Add any other context about the problem here.

@hsunwenfang hsunwenfang changed the title Not popup for my microsoft edge contents Not popup for google doc on microsoft edge Aug 26, 2024
@melink14 melink14 added MV3 and removed untriaged labels Aug 26, 2024
@melink14
Copy link
Owner

Thanks for reporting the issue. The root cause was new restrictions on how scripts can interact with web pages in manifest V3. I've tested a fix and it should be published within a day.

I'm still not sure why this didn't break in chrome though!

melink14 added a commit that referenced this issue Aug 26, 2024
…t manner

New CSP changes means we can no longer inject a script into the MAIN world from the ISOLATED world.

Instead, we use the new `world` key to inject a simple script directly into the MAIN world.

One caveat of this is that we can no longer read the extension ID dynamically (as it's not available in MAIN world) so instead we hardcode it into the script as it extremely stable.

Fixes #2175
melink14 pushed a commit that referenced this issue Aug 26, 2024
## [3.0.1](v3.0.0...v3.0.1) (2024-08-26)

### Bug Fixes

* Allow popup.css to be accessed from all URLs ([#2174](#2174)) ([5b0f3c1](5b0f3c1))
* **dict:** Update dictionaries to latest versions ([#2148](#2148)) ([c23d032](c23d032))
* **google-docs:** Set docs_annotate_canvas property in a MV3 compliant manner ([#2176](#2176)) ([a09ddaf](a09ddaf)), closes [#2175](#2175)
@melink14
Copy link
Owner

🎉 This issue has been resolved in version 3.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants
@melink14 @hsunwenfang and others