Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(manifest): Remove comment from manifest.json #2169

Merged
merged 1 commit into from
Aug 25, 2024
Merged

Conversation

melink14
Copy link
Owner

Chrome supports json comments but semantic-release-chrome does not; preventing the release of chrome.

The comment is replaced with a "//" json key.

Chrome supports json comments but semantic-release-chrome does not; preventing the release of chrome.

The comment is replaced with a "//" json key.
@melink14 melink14 merged commit d76fc31 into main Aug 25, 2024
9 of 11 checks passed
@melink14 melink14 deleted the melink14/no-comments branch August 25, 2024 14:14
melink14 pushed a commit that referenced this pull request Aug 25, 2024
## [3.0.0](v2.5.61...v3.0.0) (2024-08-25)

### ⚠ BREAKING CHANGES

* MV3 with offscreen pages requires at least Chrome 109 which is the new minimum version.

### Features

* Migrate to MV3 ([#2168](#2168)) ([8a47af3](8a47af3)), closes [#187](#187) [#65](#65)

### Bug Fixes

* **manifest:** Remove comment from manifest.json ([#2169](#2169)) ([d76fc31](d76fc31))
melink14 pushed a commit that referenced this pull request Aug 25, 2024
## [3.0.0](v2.5.61...v3.0.0) (2024-08-25)

### ⚠ BREAKING CHANGES

* MV3 with offscreen pages requires at least Chrome 109 which is the new minimum version.

### Features

* Migrate to MV3 ([#2168](#2168)) ([8a47af3](8a47af3)), closes [#187](#187) [#65](#65)

### Bug Fixes

* **manifest:** Remove comment from manifest.json ([#2169](#2169)) ([d76fc31](d76fc31))
@melink14
Copy link
Owner Author

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant