feat: port emSize prop

BREAKING CHANGE: dropped ptSize prop. Point is supposed to be an absolute (pixel independant) size and unfit for display devices. It will be translated by the CSS processor to an absolute unit.
meliorence · Jan 18, 2021 · f567532 · f567532
1 parent dab1d25
commit f567532
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 7 deletions.
diff --git a/packages/render-html/src/RenderHTML.tsx b/packages/render-html/src/RenderHTML.tsx
@@ -58,7 +58,6 @@ const propTypes: RenderHTMLPropTypes = {
  height: PropTypes.number
  }),
  emSize: PropTypes.number.isRequired,
- ptSize: PropTypes.number.isRequired,
  baseStyle: PropTypes.object,
  renderersProps: PropTypes.object,
  onTTreeChange: PropTypes.func,
@@ -82,7 +81,6 @@ const defaultProps: {
  decodeEntities: true
  },
  emSize: 14,
- ptSize: 1.3,
  ignoredTags: [],
  ignoredStyles: [],
  baseStyle: { fontSize: 14 },

diff --git a/packages/render-html/src/hooks/useTRenderEngine.ts b/packages/render-html/src/hooks/useTRenderEngine.ts
@@ -23,6 +23,7 @@ export default function useTRenderEngine(props: RenderResolvedHTMLProps) {
  fallbackFonts,
  systemFonts,
  renderers = {},
+ emSize,
  triggerTREInvalidationPropNames
  } = props;
  const isFontSupported = useMemo(() => {
@@ -99,7 +100,8 @@ export default function useTRenderEngine(props: RenderResolvedHTMLProps) {
  cssProcessorConfig: {
  isFontSupported,
  inlinePropertiesBlacklist: ignoredStyles,
- inlinePropertiesWhitelist: allowedStyles
+ inlinePropertiesWhitelist: allowedStyles,
+ rootFontSize: emSize
  },
  htmlParserOptions: {
  decodeEntities: true,

diff --git a/packages/render-html/src/shared-types.ts b/packages/render-html/src/shared-types.ts
@@ -251,10 +251,6 @@ export interface RenderHTMLProps<P = any>
  * The default value in pixels for 1em
  */
  emSize?: number;
- /**
- * The default value in pixels for 1pt
- */
- ptSize?: number;
  /**
  * Triggered when the transient render tree changes. Useful for debugging.
  */