Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

textSelectable does not work when texts are not in a tag and there are other tags #193

Closed
zhangzhhz opened this issue Nov 10, 2018 · 5 comments
Closed

textSelectable does not work when texts are not in a tag and there are other tags #193

zhangzhhz opened this issue Nov 10, 2018 · 5 comments
Labels
bug Crush'em all. is:waiting pr A pull request is awaiting reviews to solve the problem.

Comments

@zhangzhhz
Copy link

Is this a bug report or a feature request?

This is a bug report.

Have you read the guidelines regarding bug report?

yes

Have you read the documentation in its entirety?

yes

Have you made sure that your issue hasn't already been reported/solved?

yes

Is the bug specific to iOS or Android? Or can it be reproduced on both platforms?

Android (dont have an iPhone to test)

Is the bug reproductible in a production environment (not a debug one)?

yes

Have you been able to reproduce the bug in the provided example?

yes

Environment

React: 16.5.0
React native: 0.57.1
react-native-render-html: 3.10.0

React: 16.3.1
React native: 0.56
react-native-render-html: 3.10.0

Steps to Reproduce

Please refer to this snack.
https://snack.expo.io/H16whhV6Q

Expected Behavior

If textSelectable is provided, all texts should be selectable.

Reproducible Demo

https://snack.expo.io/H16whhV6Q
@zhangzhhz
Copy link
Author

zhangzhhz commented Nov 12, 2018 •
edited
Loading

Changed HTML.js and HTMLRenders.js which solved my issue.

https://github.com/archriss/react-native-render-html/compare/master...zhangzhhz:master?diff=unified#diff-c751800619b78ba633bc9c2560ccadd8

https://github.com/archriss/react-native-render-html/compare/master...zhangzhhz:master?diff=unified#diff-a3936312776f491f9ac553c888b9b68f

@roblangridge
Copy link

Would be great to see this merged into the next version

@brsaylor2
Copy link
Contributor

+1

@brsaylor2 brsaylor2 mentioned this issue Jun 26, 2019
Closed
@jsamr jsamr added bug Crush'em all. is:waiting pr A pull request is awaiting reviews to solve the problem. labels Jul 5, 2020
@jsamr jsamr mentioned this issue Jul 5, 2020
Closed
@jsamr
Copy link
Collaborator

jsamr commented Jul 18, 2020

This issue will be fixed soon. I'm implementing tests and reviewing the PR. So far, I understand that Android only considers the first Text element in the tree to apply the selectable attribute. But this library, in some occasions, applies the selectable prop deeper. I could confirm this behaviors with snapshots, and this observation matches every example provided in the snack.

jsamr added a commit that referenced this issue Jul 18, 2020
@jsamr
tests: provide regression against #193, ignored textSelectable prop
194a726
@jsamr jsamr closed this as completed in ab84ce0 Jul 18, 2020
@Saren-Arterius
Copy link

Saren-Arterius commented Oct 22, 2020 •
edited
Loading

Had the same issue as this and #362, which is <HTML> inside <FlatList>. facebook/react-native#26264 solved it for me.

@slpnchk slpnchk mentioned this issue Jul 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Crush'em all. is:waiting pr A pull request is awaiting reviews to solve the problem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix textSelectable not working for tagName textwrapper brsaylor2/react-native-render-html
5 participants
@jsamr @Saren-Arterius @roblangridge @zhangzhhz @brsaylor2