Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update react-native to ^0.64.0 in peerDependencies #508

Closed
5 tasks done
Ainias opened this issue Jul 19, 2021 · 4 comments
Closed
5 tasks done

Update react-native to ^0.64.0 in peerDependencies #508

Ainias opened this issue Jul 19, 2021 · 4 comments
Labels
bug Crush'em all.

Comments

@Ainias
Copy link

Ainias commented Jul 19, 2021

Oath

I swear that I have completed these tasks before submitting:

Decision table

  • My issue does not look like “The HTML attribute 'xxx' is ignored” (unless
    we claim support for it),
  • My issue does not look like “The HTML element <yyy> is not rendered”

Bug Report

When using react-native 0.64.x and react-native-render-html 6.0.2, npm install throws an error with unable to resolve dependency tree. When using npm install --legacy-peer-deps its working.
In the package.json delivered in the release, react-native 0.64.0 is already defined as devDependency. Therefore it should be easy to update the peerDependency.

Reproduction

  1. create empty directory
  2. create package.json with dependencies

"dependencies": {
"react-native":"^0.64.0",
"react-native-render-html": "^6.0.2"
}

  1. run npm install
@Ainias Ainias added the bug Crush'em all. label Jul 19, 2021
@jsamr
Copy link
Collaborator

jsamr commented Jul 19, 2021

@Ainias Hey thank you for your report, good catch! That's probably due to how npm 7 works (I'm using 6.x locally); I'll fix that today.

jsamr added a commit that referenced this issue Jul 19, 2021
jsamr added a commit that referenced this issue Jul 19, 2021
@jsamr jsamr closed this as completed in 002f555 Jul 19, 2021
@jsamr
Copy link
Collaborator

jsamr commented Jul 19, 2021

@Ainias Thought I fixed in release 6.0.3. I added a CI step to avoid regressions, see https://github.com/meliorence/react-native-render-html/actions/runs/1046261556 but it failed again, investigation going on ...

@jsamr jsamr reopened this Jul 19, 2021
@jsamr
Copy link
Collaborator

jsamr commented Jul 19, 2021

@Ainias I think it's fixed in 6.0.4; could you try it out? CI still fails but it worked locally...

@jsamr
Copy link
Collaborator

jsamr commented Jul 19, 2021

@Ainias Found out that it would fail with npm@7.7.6 but succeed with npm@7.20.0, because in the former, * in peerDependencies would be wrongly resolved to the latest instead of whichever; which would conflict with react-nativereact requirement. That was an npm bug!
See https://github.com/meliorence/react-native-render-html/runs/3107443720

Closing now, feel free to comment if you're still having issues.

@jsamr jsamr closed this as completed Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Crush'em all.
Projects
None yet
Development

No branches or pull requests

2 participants