Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.x] render image after get size #417

Closed
wants to merge 1 commit into from
Closed

[4.x] render image after get size #417

wants to merge 1 commit into from

Conversation

sonnt612
Copy link

@sonnt612 sonnt612 commented Oct 23, 2020 •
edited
Loading

Checks

Description

@jsamr
Copy link
Collaborator

jsamr commented Oct 29, 2020

@sonnt612 Thanks for your contribution! The appropriate branch to merge this PR into would be dev/4.x, would be nice if your could resubmit.

@sonnt612 sonnt612 changed the base branch from release/4.2 to dev/4.x November 26, 2020 07:33
@sonnt612
Copy link
Author

@sonnt612 Thanks for your contribution! The appropriate branch to merge this PR into would be dev/4.x, would be nice if your could resubmit.

ok. I changed to branch dev/4.x

jsamr
jsamr reviewed Nov 27, 2020
View reviewed changes
src/HTMLImage.js
{...props}
/>
);
if (this.state.loading) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have thought you would render the image if it is not loading?

jsamr
jsamr requested changes Nov 27, 2020
View reviewed changes
Copy link
Collaborator

@jsamr jsamr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments

@jsamr jsamr changed the title render image after get size [4.x] render image after get size Nov 27, 2020
@jsamr
Copy link
Collaborator

jsamr commented Dec 5, 2020

I'm closing because this issue has been resolved in v5.0.0 which has a very easy upgrade path from v4.x. See #442

@jsamr jsamr closed this Dec 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsamr jsamr jsamr requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sonnt612 @jsamr