-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Help wanted] Looking for maintainers #632
Comments
@bd-arc Who I amI'm a full-stack developer currently living in Japan. Reason for consideration
Experience3 years of experience in React I'm going to attempt the implementation with I've made a PR #636 to upgrade the |
Hi @Naturalclar, Thanks a lot for offering your help! Really appreciate your expertise and motivation :-) Your PR was spot on and already got merged. It speaks volume about your commitment! I really look forward to seeing what you're going to do with the new logic! Do not hesitate to ping me if you have any question or need any help. |
Hello @bd-arc, Who I amI'm a react native developer based in Cairo, EG Why I'm considering it?Because I use this plugin in most of my projects and all of their dashboards are depends on react-native-snap-carousel cause our company industry is e-commerce applications, so I wanted to help even with small tasks like Implement React hooks What's my experienceI don't have experience in open source projects but I didn't have any opportunity to contribute to any project My ContributionI will attempt to implement the component using react hooks |
Hi @Stringsaeed, Every contribution is welcome, so thank you for offering your help! Eager to review your first PR ;-) |
Just made the shiny new beta public. To everyone who has a keen interest in the plugin: I'd love your feedback ;-) |
@bd-arc how do i get beta? i need that asap. as currently, i'm using version- 3.9.1. that rely on react-native's Scrollview. that causing me problem for android devices. as, i'm using edgeWidth of @react-navigation/drawer": "^5.8.2" so its causing the freeze of sliding, after first slide. using scrollview from react-native-gesture-handler, will solve the issue. |
Hello @bd-arc, Interested if I rewrite to TS? 😄 I'm a react-native core contributor, I maintain react-native-webview which was the first lean core components, alsoI rewrote it to typescript Not looking to be a long time maintainer but rather to tackle issues here and there 🚀 |
That would be awesome @Titozzz! Thanks a lot for your offer 🙏 It's been on my to-do list for months but I still haven't taken the time to do so. Just a quick thought: I don't plan on supporting the current v3 anymore, so the TypeScript update would be a perfect addition to the current v4 WIP. Any question at this point? |
@bd-arc Are you OK with me using https://github.com/react-native-community/bob to deal with all the project build stuff ? |
@Titozzz I don't know this particular CLI solution, but as long as it helps users get into the plugin I'm all for it. Just to be sure: this will only be used with the example, right? |
@bd-arc It's a CLI to manage the builds / releases to NPM more easily, it also come with opinionated defaults for lint, etc |
@Titozzz Ok. I don't know how it compares to other solutions, but I'm trusting you: let's give it a try! |
#734 WIP -> I made this live for my first OSS stream. |
Hi @bd-arc, Who am I
Reason for consideration
Experience
|
Hi @narender2031, Thanks a lot for offering your help! Are you familiar with Typescript? If yes would you be interested in testing and reviewing #734? I'm trying to get as many pair of eyes as possible on this PR because it's a huge one :-) |
Thanks, @bd-arc, Yes. I have basics knowledge of typescript. I will take a look at this. |
me |
It's been 2 years and nothing yet? |
This comment was marked as spam.
This comment was marked as spam.
Hello! |
@bd-arc have you found some maintainers? It may be good to add some devs that already pushed code into the library. Or anything that could help to keep this project alive. Thanks! |
Seems like we are all migrating to https://www.npmjs.com/package/react-native-reanimated-carousel |
There should be a big warning in the readme stating that this lib is unmaintained! The issues are overflowing with people trying to use it only to find out it does not work anymore! |
Hello @bd-arc, are you still open to finding new maintainers, what happened? |
Thank you very much for considering becoming a maintainer! The fact that you're willing to take some time to make this plugin even better is really appreciated 👍
I'm not going to lie to you though: there's work to be done. If you want to apply, please follow the following steps:
People have lots of expectations about this plugin — it's currently downloaded more than 250,000 times every single month. So please do not apply if:
🏆 Most required updates
Here are, ranged by order of importance, the most important updates the plugin currently requires.
1. Ditch
ScrollView
andFlatList
, and implement a custom scroll logic based onreact-native-gesture-handler
andreact-native-reanimated
This is, by far, the most important step to be taken at this point. It will open the road to a whole new level of features and user experience: total control over the scroll behavior, proper callback mechanism, better loop mode, better animations, better performance, proper RTL mode, no more "trailing slide whitespace", no visual differenciation between iOS and Android with the advanced animations, and, most importantly, no more
FlatList
issues to deal with 🙏By itself, this update will solve approximately 90 % of the currently opened issues!
While it may seem like a daunted task, it happens that the folks at Software Mansion have created their own version of the carousel that does just that, and they are totally open to sharing their work (in fact,
react-native-snap-carousel
served as an inspiration for them). They've laid out a great base that just need to be improved and tailored to this plugin's needs.Note that the idea is not to use their plugin because:
Next steps
react-native-pager
plugin is not to be imported, only to be used as a reference.)2. Take care of miscellaneous bugs introduced in 3.8.x
3. Handle dynamic data (addition/removal of items)
4. Prevent unneeded rerenders
5. Implement React hooks
6. Update examples
The text was updated successfully, but these errors were encountered: