-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace ScrollView and Animated with gesturehandler and reanimated #637
base: master
Are you sure you want to change the base?
Conversation
Hi @Naturalclar, Thanks for taking the first step in the right direction for this plugin 👍 Do you mind expanding on the benefits the PR provides? Unless I'm mistaken, there will be no visible effect for the users at this point, am I right? And please don't forget to ping me when you create a PR, otherwise I will only stumble upon it randomly like I just did ;-) |
Agree! For example, some props for Pagination component (like animatedTension) aren't availables for use yet. |
Is there any benefit in the migration? |
yes. reanimated uses declarative api, rather than |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reanimated dont have .parllel() method.
Moreover just changing imports isn't gonna do the trick.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it will be any better with just changing imports especially because of software-mansion/react-native-reanimated#194
@radko93 are you thinking about migrating to reanimated ? |
@vamshi9666 not at the moment. It might not be beneficial (look at the link I've posted) |
I did. I even tried to repro his hypothesis. To be honest ,i didn't see any lags or framedrops. |
Platforms affected
iOS, Android
What does this PR do?
This PR is part of #632
replaces
Animated
,Easing
,ScrollView
, andFlatList
provided by react-native withreact-native-gesture-handler
andreact-native-reanimated
What testing has been done on this change?
Ran example App on iOS and Android Simulators
Tested features checklist
enableMomentum
)vertical
)activeSlideAlignment
)autoplay
)loop
)ScrollView
/FlatList
carousels (propuseScrollView
)ParallaxImage
componentPagination
component