Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ScrollView and Animated with gesturehandler and reanimated #637

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Naturalclar
Copy link
Contributor

@Naturalclar Naturalclar commented Dec 23, 2019

Platforms affected

iOS, Android

What does this PR do?

This PR is part of #632
replaces Animated, Easing, ScrollView, and FlatList provided by react-native with react-native-gesture-handler and react-native-reanimated

What testing has been done on this change?

Ran example App on iOS and Android Simulators

Tested features checklist

@bd-arc
Copy link
Contributor

bd-arc commented Jan 10, 2020

Hi @Naturalclar,

Thanks for taking the first step in the right direction for this plugin 👍

Do you mind expanding on the benefits the PR provides? Unless I'm mistaken, there will be no visible effect for the users at this point, am I right?

And please don't forget to ping me when you create a PR, otherwise I will only stumble upon it randomly like I just did ;-)

@CesarGomezTissini
Copy link

CesarGomezTissini commented Feb 10, 2020

Agree! For example, some props for Pagination component (like animatedTension) aren't availables for use yet.

@radko93
Copy link
Contributor

radko93 commented Feb 19, 2020

Is there any benefit in the migration?

@vamshi9666
Copy link

vamshi9666 commented Feb 26, 2020

yes. reanimated uses declarative api, rather than .start() and .stop().So all animated values will be declared and manipulated on ui thread and doesn't depend on any js operation.
In this video Varun explains, why reanimated is smoother

Copy link

@vamshi9666 vamshi9666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reanimated dont have .parllel() method.
Moreover just changing imports isn't gonna do the trick.

Copy link
Contributor

@radko93 radko93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it will be any better with just changing imports especially because of software-mansion/react-native-reanimated#194

@vamshi9666
Copy link

@radko93 are you thinking about migrating to reanimated ?

@radko93
Copy link
Contributor

radko93 commented Mar 2, 2020

@vamshi9666 not at the moment. It might not be beneficial (look at the link I've posted)

@vamshi9666
Copy link

I did. I even tried to repro his hypothesis. To be honest ,i didn't see any lags or framedrops.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants