Use List instead of ListProperty for benchmarkParameters
values
#206
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
ex) line/armeria#3811
It seems like most usages assume that the parameter values are
List
rather thanListProperty
ref: https://github.com/search?l=Gradle&p=5&q=benchmarkParameters&type=Code
Using previous code naively, the following exception is raised:
A workaround exists so I wouldn't say this is critical, but I was wondering if this API change was intentional.
Modification
addMapOption
to receive aList
value instead of aListProperty
value