Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debug Panel improvements #108

Closed
melonjs opened this issue Sep 19, 2012 · 14 comments
Closed

Debug Panel improvements #108

melonjs opened this issue Sep 19, 2012 · 14 comments
Labels
Improvement
Milestone
1.1.0

Comments

@melonjs
Copy link
Collaborator

melonjs commented Sep 19, 2012

While I still have them fresh in my mind, here is a list of potential improvements for the new Debug Panel :

  • add the possibility to show/hide the panel through a parameter in the URL
  • add Chrome memory/heap profiling information (see for example : http://coderwall.com/p/2va2mg)
  • track objects total update duration
  • track objects total draw duration
  • track numbers of rect created (N/A)
  • add some useful graphs ? (heap, update/draw duration ?)
  • add a basic console
  • make it scalable (canvas size independant)
  • make it a float object (on top of the game canvas and not in the canvas)
@parasyte
Copy link
Collaborator

I'd like to see some debug numbers for loaded resources, too:

  • Number of images loaded
  • Number of sound files loaded
  • Number of XML files loaded
  • Number of binary files loaded
  • Number of open audio channels
  • Number of audio channels playing

@melonjs
Copy link
Collaborator Author

melonjs commented Sep 24, 2012

Good ones too, I guess we will need a bigger debug panel :)

@parasyte
Copy link
Collaborator

Would the "basic console" provide anything that window.console doesn't? We already get messages and can run JavaScript in them. ;)

Could be useful I guess for old IE...

@greghouston
Copy link

Per frame statistics would be cool. See Florian's comment on this article:

https://blog.mozilla.org/javascript/2012/08/28/incremental-gc-in-firefox-16/

melonjs pushed a commit that referenced this issue Oct 30, 2012
ticket #108: added a simple used heap graph (chrome only)
6eb98ba 
this still require more works :
* better use window.performance.memory (cache the object)
* make this works on other webkit browser (Safari has some stuff too)
* avoid generating more object (e.g Array.shift)
* probably a bit better algorithm when computing the sample points
* add more information into the graph
@melonjs
Copy link
Collaborator Author

melonjs commented Nov 28, 2012

I was just thinking that refactoring the debug Panel using the plugin mechanism would be a good idea, any thoughts ?

the point being that once in production, the corresponding (debug) code is completely useless.

melonjs pushed a commit that referenced this issue Dec 26, 2012
Ticket #108 : Converted me.debug.Panel into an official plugin
2fc6067
melonjs pushed a commit that referenced this issue Jan 21, 2013
Ticket #108 : added the possibility to pass arguments to the plugin c…
981ea57 
…onstructor (through the register function)
@melonjs
Copy link
Collaborator Author

melonjs commented Jan 28, 2013

i'm updating the milestone for this one (0.9.6), as I won't provide anymore update for the coming 0.9.5

@nvlbg
Copy link
Contributor

nvlbg commented Jan 28, 2013

I must add a bug I just found. If the viewport offset is not (0,0), the click area is not correct. So if the camera is moved to (100,100) for example and you click on the renderHigBox checkbox, it won't detect it as a click.

@melonjs
Copy link
Collaborator Author

melonjs commented Jan 28, 2013

Hi @nvlbg

Using the very last version (0.9.5), and the provided "platformer" example (where the debug panel is used) I cannot reproduce it on my side. Do you have a specific example where I could the issue ?

@nvlbg
Copy link
Contributor

nvlbg commented Jan 28, 2013

Actually, it looks like if the cam is moved on the x axis this does not happen, but it happens when the cam is moved on the y axis. You can check it here - http://92.62.251.95:8080/

P.S. It is my local server, so it is not up 24/7.

melonjs pushed a commit that referenced this issue Jan 28, 2013
ticket #108: fixed mouse position detection when the viewport offset …
84232f6 
…is not (0,0)
@melonjs
Copy link
Collaborator Author

melonjs commented Jan 28, 2013

@nvlbg fixed !

@obiot
Copy link
Member

obiot commented Apr 17, 2013

Moving this one as well to 0.9.8 as I don't believe further improvements will be done as part of 0.9.7 ;)

@obiot
Copy link
Member

obiot commented Jul 21, 2013

An internesting lib that would allow to design a better debug panel :
http://code.google.com/p/dat-gui/

obiot pushed a commit that referenced this issue Aug 2, 2013
[#108] directly query information from me.game.world
b7826e7
obiot added a commit that referenced this issue Aug 27, 2013
@obiot
[#108] also moved the fps counting to the debugPanel
8af7dab 
FPS information is now only available through the debug panel object
(and not anymore through the HTML element)

(Only one left now : me.debug.renderCollisionMap!)
@agmcleod
Copy link
Collaborator

agmcleod commented Dec 5, 2013

Added basic update & draw millisecond durations: 63072b1

@obiot obiot mentioned this issue Jan 21, 2014
Merged
@obiot obiot modified the milestones: 1.1.0, 1.0.0 Mar 4, 2014
@obiot
Copy link
Member

obiot commented Jul 23, 2014

i'm not seing anything major left here, so I will close it for now. if any particular feature stands out (that I don't see here), we can then open a new ticket

@obiot obiot closed this as completed Jul 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Improvement
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
5 participants
@greghouston @agmcleod @parasyte @nvlbg @obiot