Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Texture packer support for tiles #592

Closed
agmcleod opened this issue Oct 22, 2014 · 7 comments
Closed

Texture packer support for tiles #592

agmcleod opened this issue Oct 22, 2014 · 7 comments
Milestone
2.1.0

Comments

@agmcleod
Copy link
Collaborator

Not sure how this will work, but it would be nice to get working. Problem is if position of a tileset changes inside the atlas'd image, the map will be all wrong. But if anyone has any clever ideas, would be great to implement. Especially for when we get batching in for webgl.
@parasyte
Copy link
Collaborator

I don't know about supporting the TexturePacker (or ShoeBox) format with tilesets, because Tiled doesn't have this feature. But reusing the internal structure for #591 will be very useful.

@parasyte parasyte modified the milestone: 1.3.0 Oct 22, 2014
@obiot obiot mentioned this issue Dec 9, 2014
Closed
@obiot
Copy link
Member

obiot commented Dec 21, 2014

@parasyte if you work on the batch drawing, i will take care of this one :)

@obiot obiot closed this as completed Dec 21, 2014
@obiot obiot reopened this Dec 21, 2014
@obiot
Copy link
Member

obiot commented Dec 21, 2014

Close/open : wrong button :p

@parasyte
Copy link
Collaborator

Ok, this was actually going to be part of #591 (kind of) along with #595. This ticket is actually really important for WebGL, as it will allow creating the UV maps for each tile that are necessary for the batching.

As long as our visions don't collide here, I will appreciate the help. ☺️

@obiot
Copy link
Member

obiot commented Dec 24, 2014

with #392 being done it should be quite straightforward now : just update the me,tileset object to use a texture atlas (the constructor can takes an object that also include spacing and margin as required for a tileset), and match each me.Tile object with the corresponding region.

parasyte referenced this issue Jan 19, 2015
@obiot
[#591] added missing webgl coordinates when building textures out of …
335e50c 
…spritesheet

some redundant code to be removed later.
obiot added a commit that referenced this issue Jan 20, 2015
@obiot
[#592] split source files for better readability
e33833f
obiot added a commit that referenced this issue Jan 20, 2015
@obiot
[#592] use a texture atlas to calculate/store all offsets and draw tiles
1c1bf6e 
tested for regression with multiple tilesets (2) and did not see any
issues.
parasyte added a commit that referenced this issue Jan 20, 2015
@parasyte
Remove the spritesheet-in-texture code.
6217ecd 
- It does not play nice with the new Texture system
- It will not work well with WebGL when arbitrary texture coordinates are removed (though we could generalize such a workflow by creating atlases at runtime ... that's necessary for #592 anyway)
- This reverts #458
obiot added a commit that referenced this issue Jan 21, 2015
@obiot
[#592] few improvements following comments on yesterday commit
77d72c5
@obiot
Copy link
Member

obiot commented Jan 23, 2015

i think that one is done and can be closed ?

the last point remaining is the required revamping on the tiledObject, that is already covered by ticket #595

parasyte added a commit that referenced this issue Jan 23, 2015
@parasyte
[#592] First attempt at Tile-Object-as-a-Texture
ef6967f
obiot added a commit that referenced this issue Jan 23, 2015
@obiot
[#592] wip attempt at using texture atlas for tiledObject
0f68ac8
obiot added a commit that referenced this issue Jan 27, 2015
@obiot
[#592] attempt at combining both ticket/ideas into something that work
d5f8578
obiot added a commit that referenced this issue Jan 27, 2015
@obiot
[#592] simplified cleared the me.Tile function signature
0b7b117 
now better matches the libTiled implementation
obiot added a commit that referenced this issue Jan 27, 2015
@obiot
[#592] fixed typo (and bugs) in the flip flags
610169f 
why is the second spike tile never drawn ???
obiot added a commit that referenced this issue Jan 27, 2015
@obiot
[#592] that one too...
06d25dd
obiot added a commit that referenced this issue Jan 27, 2015
@obiot
[#592] moved the getTileObject to me.Tile and also renamed it
08b3b91
parasyte added a commit that referenced this issue Jan 27, 2015
@parasyte
[#592] Convert tileId to local tile ID in me.Tile.getRenderable()
5a296fb 
- See also: https://github.com/melonjs/melonJS/blob/08b3b91dc1a744e67aa8f6d4a4b6f24d1e49c065/src/level/TMXTileset.js#L205
obiot added a commit that referenced this issue Jan 28, 2015
@obiot
[#592] fixed a regression with TMX loading
d79b6c1 
the visible flag is only optional in the TMX file (always present when
exported to JSON), and if not present the default value is true (with
the last change, it was set to false)
@obiot
Copy link
Member

obiot commented Jan 28, 2015

merged this ticket into master.

Two things missings now (linked but not related to this ticket) :

@obiot obiot closed this as completed Jan 28, 2015
@obiot obiot mentioned this issue Jan 28, 2015
Closed
obiot added a commit that referenced this issue Jan 28, 2015
@obiot
[#592] post-merge cleaning :P
cf43d07
obiot added a commit that referenced this issue Jan 28, 2015
@obiot
[#592] cleaned the platformer level from test objects
6eaa737
@parasyte parasyte mentioned this issue Feb 7, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1.0
Development

No branches or pull requests
3 participants
@agmcleod @parasyte @obiot