Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: quieter logs when polling schedule changes #28

Merged
merged 2 commits into from
Sep 14, 2022

Conversation

aaronsteers
Copy link
Contributor

@simonpai
Copy link

I can confirm this fix works (in the scenario without a custom logging config file).
We can probably also leave comments like this:

list_result = subprocess.run(
    # Suppress info-level log from CLI reduce large amount of log messages.
    # If you have your own logging configuration which overrides the log level switch,
    # Set log level to WARNING on logger: meltano.cli to achieve the same effect.
    [MELTANO_BIN, "--log-level=warning", "schedule", "list", "--format=json"],

@aaronsteers
Copy link
Contributor Author

aaronsteers commented Sep 14, 2022

@pandemicsyn - Apologies for the delay. I added an explanatory comment and a constant at the top of the file for easier configuration.

Merging now.

@aaronsteers aaronsteers merged commit 971046e into main Sep 14, 2022
@aaronsteers aaronsteers deleted the aj-quieter-polling branch September 14, 2022 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Airflow causes meltano to print log every few seconds
3 participants