Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default selection criteria for facebook pages #1295

Merged
merged 4 commits into from
May 9, 2023

Conversation

pnadolny13
Copy link
Contributor

@pnadolny13 pnadolny13 commented May 5, 2023

Closes #1083

The goes-funky variant looks like it already updated the SDK version to fix the install bug in goes-funky/tap-facebook-pages#24. While I was exploring I noticed that the voxmedia variant uses a custom workflow where it queries bigquery to get inputs for the request voxmedia/tap-facebook-pages#8 (comment).

UPDATE [05-08-23] - I decided that the best path forward would be to add default selection criteria that should allow the tap to work by default for everyone and added a note to the settings preamble section to explain why the selection criteria exists.

I think the two options are:

  1. hide the voxmedia variant since it has hardcoded custom logic
  2. add select criteria that avoids that custom logic as proven by @acarter24 in Credentials for GCS needed? voxmedia/tap-facebook-pages#8 (comment)

The easy solution, and the one I proposed here, is to to hide the variant but the downside is that users lose track of good SDK alternative variants. Its possible in the future the goes-funky variant goes stale, it would be nice to not lose track of voxmedia in case we need to make it default in the future.

Long term having something like meltano/sdk#1652 (cc @edgarrmondragon ) to default the tap to deselect those streams would be ideal.

@pnadolny13 pnadolny13 temporarily deployed to preview May 5, 2023 16:29 — with GitHub Actions Inactive
@netlify
Copy link

netlify bot commented May 5, 2023

Deploy Preview for meltano-hub ready!

Name Link
🔨 Latest commit 680e6e7
🔍 Latest deploy log https://app.netlify.com/sites/meltano-hub/deploys/645ac3d3a0f38e0008032f48
😎 Deploy Preview https://deploy-preview-1295--meltano-hub.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@pnadolny13 pnadolny13 temporarily deployed to preview May 5, 2023 16:30 — with GitHub Actions Inactive
@pnadolny13 pnadolny13 temporarily deployed to preview May 8, 2023 13:52 — with GitHub Actions Inactive
@pnadolny13 pnadolny13 marked this pull request as ready for review May 8, 2023 13:52
@pnadolny13 pnadolny13 temporarily deployed to preview May 8, 2023 13:52 — with GitHub Actions Inactive
@pnadolny13 pnadolny13 temporarily deployed to preview May 8, 2023 13:54 — with GitHub Actions Inactive
@pnadolny13 pnadolny13 changed the title hide fb pages tap that has a custom implementation Hide fb pages tap that has a custom implementation May 9, 2023
@pnadolny13 pnadolny13 changed the title Hide fb pages tap that has a custom implementation Default selection criteria for facebook pages May 9, 2023
@pnadolny13 pnadolny13 temporarily deployed to preview May 9, 2023 22:06 — with GitHub Actions Inactive
@pnadolny13 pnadolny13 enabled auto-merge (squash) May 9, 2023 22:06
@pnadolny13 pnadolny13 merged commit 35173ff into main May 9, 2023
@pnadolny13 pnadolny13 deleted the hide_voxmedia_fb_pages branch May 9, 2023 22:07
@pnadolny13 pnadolny13 temporarily deployed to preview May 9, 2023 22:08 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tap-facebook-pages default variant
2 participants