Default selection criteria for facebook pages #1295
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1083
The goes-funky variant looks like it already updated the SDK version to fix the install bug in goes-funky/tap-facebook-pages#24. While I was exploring I noticed that the voxmedia variant uses a custom workflow where it queries bigquery to get inputs for the request voxmedia/tap-facebook-pages#8 (comment).
UPDATE [05-08-23] - I decided that the best path forward would be to add default selection criteria that should allow the tap to work by default for everyone and added a note to the settings preamble section to explain why the selection criteria exists.
I think the two options are:
The easy solution, and the one I proposed here, is to to hide the variant but the downside is that users lose track of good SDK alternative variants. Its possible in the future the goes-funky variant goes stale, it would be nice to not lose track of voxmedia in case we need to make it default in the future.
Long term having something like meltano/sdk#1652 (cc @edgarrmondragon ) to default the tap to deselect those streams would be ideal.