Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(templates): Move tests in cookiecutters to project root to support pytest_plugins #1380

Merged
merged 6 commits into from
Feb 9, 2023

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Feb 1, 2023

Closes #1377


📚 Documentation preview 📚: https://meltano-sdk--1380.org.readthedocs.build/en/1380/

@codecov
Copy link

codecov bot commented Feb 1, 2023

Codecov Report

Merging #1380 (89d4c29) into main (a304bb2) will not change coverage.
The diff coverage is n/a.

❗ Current head 89d4c29 differs from pull request most recent head 2113463. Consider uploading reports for the commit 2113463 to get more accurate results

@@           Coverage Diff           @@
##             main    #1380   +/-   ##
=======================================
  Coverage   85.19%   85.19%           
=======================================
  Files          54       54           
  Lines        4722     4722           
  Branches      803      803           
=======================================
  Hits         4023     4023           
  Misses        507      507           
  Partials      192      192           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@edgarrmondragon edgarrmondragon enabled auto-merge (squash) February 1, 2023 22:23
@edgarrmondragon
Copy link
Collaborator Author

@kgpayne I would appreciate your 👀 on this PR. This may be a blocker for new taps and targets created from the cookiecutter templates to start using the new testing framework immediately.

auto-merge was automatically disabled February 8, 2023 20:13

Merge queue setting changed

@kgpayne
Copy link
Contributor

kgpayne commented Feb 9, 2023

LGTM @edgarrmondragon 🚢 I did this in tap-snowflake but didn't clock that it might be a wider issue 🤦‍♂️ Once this merges, we should update the testing guide. IIRC the pytest error is quite clear, but still useful to document 🙂 Looks like there isn't an explicit migration guide, but I updated the testing docs with the new location.

@kgpayne kgpayne requested review from a team as code owners February 9, 2023 14:55
@edgarrmondragon edgarrmondragon merged commit 441533c into main Feb 9, 2023
@edgarrmondragon edgarrmondragon deleted the fix/cookiecutter-move-tests branch February 9, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Consider moving cookiecutter tests to root of generated project to facilitate test discovery
2 participants