Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: CI tox dependency in cookiecutter #1481

Closed
1 task done
radbrt opened this issue Mar 5, 2023 · 0 comments · Fixed by #1482
Closed
1 task done

bug: CI tox dependency in cookiecutter #1481

radbrt opened this issue Mar 5, 2023 · 0 comments · Fixed by #1482
Assignees
@WillDaSilva
Labels
kind/Bug Something isn't working valuestream/SDK

Comments

@radbrt
Copy link
Contributor

radbrt commented Mar 5, 2023

Singer SDK Version

0.21.0

Is this a regression?

  • Yes

Python Version

3.9

Bug scope

Cookiecutter templates

Operating System

macOS

Description

Tox dev-dependency was removed in PR #1345, the cookiecutter CI template now fails on linting because it doesn't find tox. Should we add an install tox step in the github CI cookiecutter template?

Code

No response
@radbrt radbrt added kind/Bug Something isn't working valuestream/SDK labels Mar 5, 2023
@WillDaSilva WillDaSilva self-assigned this Mar 5, 2023
WillDaSilva added a commit that referenced this issue Mar 5, 2023
@WillDaSilva
fix: Use pipx to run tox in CI template
537df02 
Plus some related cleanup. Poetry still needs to be installed before running `pipx run tox ...` because tox is configured to use poetry from the external environment, rather than installing it into the tox venv.

Supersedes:
- #1476

Closes #1481
@WillDaSilva WillDaSilva mentioned this issue Mar 5, 2023
Merged
edgarrmondragon pushed a commit that referenced this issue Mar 6, 2023
@WillDaSilva
fix: Use pipx to run tox in CI template (#1482)
b18bc7d 
Plus some related cleanup. Poetry still needs to be installed before running `pipx run tox ...` because tox is configured to use poetry from the external environment, rather than installing it into the tox venv.

Supersedes:
- #1476

Closes #1481
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@WillDaSilva WillDaSilva

Labels
kind/Bug Something isn't working valuestream/SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Use pipx to run tox in CI template meltano/sdk
2 participants
@radbrt @WillDaSilva