fix: datetime.datetime instances in stream maps are now correctly mapped to date-time JSON schema strings
#2741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…` JSON schema strings
1 task
edgarrmondragon
changed the title
datetime.datetime instances are correctly mapped to date-time JSON schema stringsdatetime.datetime instances are now correctly mapped to date-time JSON schema strings
CodSpeed Performance ReportMerging #2741 will not alter performanceComparing Summary
|
edgarrmondragon
changed the title
datetime.datetime instances are now correctly mapped to date-time JSON schema stringsdatetime.datetime instances in stream maps are now correctly mapped to date-time JSON schema strings
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2741 +/- ##
=======================================
Coverage 90.67% 90.67%
=======================================
Files 62 62
Lines 5021 5021
Branches 641 641
=======================================
Hits 4553 4553
Misses 326 326
Partials 142 142 ☔ View full report in Codecov by Sentry. |
edgarrmondragon
deleted the
2739-bug-customstreammap-always-convert-datetime-field-to-date
branch
edgarrmondragon
added a commit
that referenced
this pull request
Nov 11, 2024
…apped to `date-time` JSON schema strings (#2741) fix: `datetime.datetime` instances are correctly mapped to `date-time` JSON schema strings
edgarrmondragon
added a commit
that referenced
this pull request
Nov 27, 2024
… schemas (#2566) * refactor: Standardize on JSON Schema Draft 2020-12 to validate stream schemas * chore(deps): bump pip from 24.2 to 24.3.1 in /.github/workflows in the ci group (#2733) chore(deps): bump pip in /.github/workflows in the ci group Bumps the ci group in /.github/workflows with 1 update: [pip](https://github.com/pypa/pip). Updates `pip` from 24.2 to 24.3.1 - [Changelog](https://github.com/pypa/pip/blob/main/NEWS.rst) - [Commits](pypa/pip@24.2...24.3.1) --- updated-dependencies: - dependency-name: pip dependency-type: direct:production update-type: version-update:semver-minor dependency-group: ci ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * test: Test `parquet` extra on Python 3.13 (#2734) * test: Test `parquet` extra on Python 3.13 * Remove xfails * chore: pre-commit autoupdate (#2735) * chore: pre-commit autoupdate updates: - [github.com/astral-sh/ruff-pre-commit: v0.7.0 → v0.7.1](astral-sh/ruff-pre-commit@v0.7.0...v0.7.1) * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * packaging: Skip `simpleeval` 1.0.1 (#2736) * chore(deps): bump pypa/gh-action-pypi-publish from 1.10.3 to 1.11.0 in the actions group (#2737) chore(deps): bump pypa/gh-action-pypi-publish in the actions group Bumps the actions group with 1 update: [pypa/gh-action-pypi-publish](https://github.com/pypa/gh-action-pypi-publish). Updates `pypa/gh-action-pypi-publish` from 1.10.3 to 1.11.0 - [Release notes](https://github.com/pypa/gh-action-pypi-publish/releases) - [Commits](pypa/gh-action-pypi-publish@v1.10.3...v1.11.0) --- updated-dependencies: - dependency-name: pypa/gh-action-pypi-publish dependency-type: direct:production update-type: version-update:semver-minor dependency-group: actions ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: Run `poetry lock` (#2738) * chore: pre-commit autoupdate (#2740) updates: - [github.com/astral-sh/ruff-pre-commit: v0.7.1 → v0.7.2](astral-sh/ruff-pre-commit@v0.7.1...v0.7.2) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * fix: `datetime.datetime` instances in stream maps are now correctly mapped to `date-time` JSON schema strings (#2741) fix: `datetime.datetime` instances are correctly mapped to `date-time` JSON schema strings * feat(targets): SQL target developers can now more easily override the mapping from JSON schema to SQL column type (#2732) * feat(target): SQL target developers can now more easily override the mapping from JSON schema to SQL column type * Add failing test for complex type case * Correctly handle multiple types * Make mypy happy * Test more cases * Add docs * Fix annotation in docs * Support custom fallbacks * Add a way to customize raw string handling * feat(templates): Update dependencies in templates (#2742) * refactor: Deprecate passing file paths to plugin and stream initialization (#2743) * docs: Document the current release process (#2745) * chore: Update issue types in templates * ci: Run tests on `v*` branches (#2747) * chore(deps): bump the actions group with 2 updates (#2748) Bumps the actions group with 2 updates: [pypa/gh-action-pypi-publish](https://github.com/pypa/gh-action-pypi-publish) and [commitizen-tools/commitizen-action](https://github.com/commitizen-tools/commitizen-action). Updates `pypa/gh-action-pypi-publish` from 1.11.0 to 1.12.2 - [Release notes](https://github.com/pypa/gh-action-pypi-publish/releases) - [Commits](pypa/gh-action-pypi-publish@v1.11.0...v1.12.2) Updates `commitizen-tools/commitizen-action` from 0.21.0 to 0.22.0 - [Release notes](https://github.com/commitizen-tools/commitizen-action/releases) - [Changelog](https://github.com/commitizen-tools/commitizen-action/blob/master/CHANGELOG.md) - [Commits](commitizen-tools/commitizen-action@0.21.0...0.22.0) --- updated-dependencies: - dependency-name: pypa/gh-action-pypi-publish dependency-type: direct:production update-type: version-update:semver-minor dependency-group: actions - dependency-name: commitizen-tools/commitizen-action dependency-type: direct:production update-type: version-update:semver-minor dependency-group: actions ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: Release v0.42.0 (#2749) * chore: Bump package version * Update dev deps --------- Co-authored-by: edgarrmondragon <16805946+edgarrmondragon@users.noreply.github.com> Co-authored-by: Edgar Ramírez-Mondragón <edgarrm358@gmail.com> * refactor: Dropped support for Python 3.8 (#2751) * refactor: Dropped support for Python 3.8 * Update tests/core/test_connector_sql.py --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: MeltyBot <105875157+MeltyBot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://meltano-sdk--2741.org.readthedocs.build/en/2741/