Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HF endpoint in embedder #1436

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

Dev-Khant
Copy link
Collaborator

@Dev-Khant Dev-Khant commented Jun 21, 2024

Description

Support for huggingface endpoint for embedding models

Fixes #1434

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Unit Test

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Made sure Checks passed

Copy link

codecov bot commented Jun 21, 2024

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 54.37%. Comparing base (e3e107b) to head (c0302e8).
Report is 1 commits behind head on main.

Files Patch % Lines
embedchain/embedder/huggingface.py 57.14% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1436   +/-   ##
=======================================
  Coverage   54.36%   54.37%           
=======================================
  Files         162      162           
  Lines        6478     6485    +7     
=======================================
+ Hits         3522     3526    +4     
- Misses       2956     2959    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@deshraj deshraj merged commit f6ddd5f into mem0ai:main Jun 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

huggingface endpoint URL not implemented for embedder part of the config.yaml
2 participants