Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix query filter in azure ai search #2171

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

junmo1215
Copy link

@junmo1215 junmo1215 commented Jan 22, 2025

Description

This pull request fixes the issue where the AzureAISearch vector store does not correctly handle the user_id filter, causing updates intended for one user to overwrite another user's memory.

Fixes #2170

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Ran the sample code provided in the issue to ensure that each user's memories are correctly added and retrieved without interference.

Please delete options that are not relevant.

  • Test Script (please provide)
m_alice = m.add("my name is Alice", user_id="Alice")
m_bob = m.add("my name is Bob", user_id="Bob")
print("m_alice: ", m_alice)
print("m_bob: ", m_bob)

time.sleep(10)
print("Final:")
pprint(m.get_all())

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

@CLAassistant
Copy link

CLAassistant commented Jan 22, 2025

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in AzureAISearch Vector Store: user_id Filter Not Working Correctly
2 participants