Write function to get child pid in tests #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mat-hek
requested changes
Dec 16, 2022
lib/membrane/testing/utils.ex
Outdated
| child_ref = Child.ref(child_name, opts) | ||
|
|
||
| try do | ||
| case :sys.get_state(parent_pid) do |
There was a problem hiding this comment.
This is meant for debugging purposes and relies on the core internals. Instead, do a normal call to the testing pipeline and make it take the PID from the context.
FelonEkonom
force-pushed
the
get-child-pid
branch
from
c37f825
to
1d5fc35
Compare
FelonEkonom
force-pushed
the
get-child-pid
branch
from
1d5fc35
to
b93b55e
Compare
FelonEkonom
force-pushed
the
get-child-pid
branch
from
fd918c6
to
949855f
Compare
varsill
requested changes
Dec 23, 2022
mat-hek
requested changes
Dec 23, 2022
lib/membrane/testing/pipeline.ex
Outdated
Comment on lines
270
to
272
| try do | ||
| GenServer.call(parent_pid, msg) | ||
| catch |
There was a problem hiding this comment.
You can use Message.call instead, it handles the case when the process is not alive
lib/membrane/testing/utils.ex
Outdated
Comment on lines
21
to
28
| msg = Message.new(:get_child_pid, child_ref) | ||
|
|
||
| try do | ||
| GenServer.call(parent_pid, msg) | ||
| catch | ||
| :exit, {:noproc, {GenServer, :call, [^parent_pid, ^msg | _tail]}} -> | ||
| {:error, :parent_not_alive} | ||
| end |
lib/membrane/testing/utils.ex
Outdated
| """ | ||
| @spec get_child_pid(pid(), Child.ref_t()) :: | ||
| {:ok, pid()} | {:error, :parent_not_alive | :child_not_found} | ||
| def get_child_pid(parent_pid, child_ref) do |
There was a problem hiding this comment.
This was to be moved to Membrane.Testing.Pipeline
mat-hek
approved these changes
Dec 23, 2022
| @@ -0,0 +1,104 @@ | |||
| defmodule Membrane.Testing.GetChildPidTest do | |||
There was a problem hiding this comment.
now this can be moved to testing pipeline tests
varsill
requested changes
Dec 27, 2022
lib/membrane/testing/pipeline.ex
Outdated
| If second argument is a child reference, function gets pid of this child | ||
| from pipeline. | ||
|
|
||
| Id second argument is a path of child references, function gets pid of |
There was a problem hiding this comment.
Suggested change
| Id second argument is a path of child references, function gets pid of | |
| If second argument is a path of child references, function gets pid of |
FelonEkonom
force-pushed
the
get-child-pid
branch
from
0137ccf
to
dd39507
Compare
FelonEkonom
force-pushed
the
get-child-pid
branch
from
b1143cb
to
7395d02
Compare
varsill
approved these changes
Jan 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Jira ticket: https://membraneframework.atlassian.net/browse/MC-134