Rename handle_write and handle_process to handle_buffer #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FelonEkonom
force-pushed
the
handle-buffer
branch
from
8b3f050
to
d01817b
Compare
mat-hek
requested changes
Jan 11, 2023
| @@ -82,7 +82,7 @@ defmodule Membrane.Core.Element.BufferController do | |||
| end | |||
|
|
|||
| @doc """ | |||
| Executes `handle_process_list` or `handle_write_list` callback. | |||
| Executes `handle_buffer_list` or `handle_buffer_list` callback. | |||
|
|
||
| For pads in push mode it is invoked when buffers arrive. | ||
| """ | ||
| @callback handle_buffer_list( |
There was a problem hiding this comment.
Maybe it could be called handle_buffers or handle_buffers_batch or at least handle_buffers_list?
| @@ -48,6 +46,38 @@ defmodule Membrane.Element.WithInputPads do | |||
| state :: Element.state_t() | |||
| ) :: Membrane.Element.Base.callback_return_t() | |||
|
|
|||
| @doc """ | |||
| Callback that is called when buffer should be written by the Element. | |||
There was a problem hiding this comment.
'written' seems no longer accurate
| @@ -8,7 +8,7 @@ defmodule Membrane.Testing.SinkTest do | |||
| test "demands when autodemand is true" do | |||
| @@ -20,7 +20,7 @@ defmodule Membrane.Testing.EndpointTest do | |||
| test "demands when autodemand is true" do | |||
FelonEkonom
force-pushed
the
handle-buffer
branch
from
b0c3f16
to
e72306d
Compare
mat-hek
approved these changes
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Jira ticket: https://membraneframework.atlassian.net/browse/MC-139