Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove _t suffix from types #509

Merged
merged 1 commit into from
Jan 13, 2023
Merged

remove _t suffix from types #509

merged 1 commit into from
Jan 13, 2023

Conversation

mat-hek
Copy link
Member

@mat-hek mat-hek commented Jan 12, 2023 •
edited
Loading

Used the following regex (in VS Code) :D
from _t([^a-z]|$)
to $1

@mat-hek mat-hek requested a review from varsill January 12, 2023 18:01
varsill
varsill requested changes Jan 13, 2023
View reviewed changes
Copy link
Contributor

@varsill varsill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to preserve that regex for the posterity :D

CHANGELOG.md Show resolved Hide resolved
guides/upgrading/v0.11.md Outdated
@@ -292,7 +292,7 @@ Rename `Membrane.Time.to_<unit name>/1` into `Membrane.Time.round_to_<unit name>
```

## Update the children definitions
Children defintions syntax (previously known as `ParentSpec`, after the name of a structure used to define children), that was used in `Membrane.Pipeline.Action.spec_t` and `Membrane.Bin.Action.spec_t` actions, has changed.
Children defintions syntax (previously known as `ParentSpec`, after the name of a structure used to define children), that was used in `Membrane.Pipeline.Action.spec` and `Membrane.Bin.Action.spec` actions, has changed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure we should change it there

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why so?

Copy link
Contributor

@varsill varsill Jan 13, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, we are refering to somthing that WAS used in ... - back then, it was Membrane.Pipeline.Action.spec_t, not Membrane.Pipeline.Action.spec :D

lib/membrane/core/pipeline/zombie.ex Show resolved Hide resolved
@mat-hek mat-hek changed the title remove _t sufix from types remove _t suffix from types Jan 13, 2023
@mat-hek mat-hek requested a review from varsill January 13, 2023 12:28
varsill
varsill approved these changes Jan 13, 2023
View reviewed changes
Copy link
Contributor

@varsill varsill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥇

Base automatically changed from unify_mode_and_demand_mode to master January 13, 2023 13:54
@mat-hek mat-hek merged commit 4bba6b7 into master Jan 13, 2023
@mat-hek mat-hek deleted the type-sufix branch January 13, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@varsill varsill varsill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mat-hek @varsill