Crash groups in bins #521
Merged
Crash groups in bins #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, but it's spec is not ready yet
…ile specs are processed
mat-hek
changed the base branch from
master
to
handle-child-pad-removed-bug-fix
FelonEkonom
force-pushed
the
handle-child-pad-removed-bug-fix
branch
from
fc820bf to
515984d
Compare
FelonEkonom
force-pushed
the
handle-child-pad-removed-bug-fix
branch
from
515984d to
ad72e26
Compare
mat-hek
reviewed
Feb 15, 2023
lib/membrane/children_spec.ex
Outdated
| @@ -318,7 +318,7 @@ defmodule Membrane.ChildrenSpec do | |||
|
|
|||
| @type children_spec_options :: [ | |||
| group: Child.group(), | |||
| crash_group_mode: Membrane.CrashGroup.mode() | nil, | |||
| crash_group_mode: Membrane.CrashGroup.mode(), | |||
There was a problem hiding this comment.
Suggested change
| crash_group_mode: Membrane.CrashGroup.mode(), | |
| crash_group_mode: :temporary | nil, |
and we can remove Membrane.CrashGroup altogether.
There was a problem hiding this comment.
It is used in 2 other places as well, so I can remove this CrashGroup module and move typespec to the another file, but I would still have a typespec describing :temporary | nil
mat-hek
approved these changes
Feb 16, 2023
FelonEkonom
force-pushed
the
crash-groups-in-bins
branch
from
1902fde to
1266f2d
Compare
…nore :child_pad_removed from terminating children
FelonEkonom
force-pushed
the
crash-groups-in-bins
branch
from
1266f2d to
3357e8e
Compare
mat-hek
reviewed
Feb 16, 2023
lib/membrane/core/pipeline/zombie.ex
Outdated
| Membrane.Pipeline.behaviour_info(:callbacks) | ||
| Membrane.Bin.behaviour_info(:callbacks) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Jira ticket: https://membraneframework.atlassian.net/browse/MC-143