Fix test failing on elixir 1.15 #592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FelonEkonom
added
the
no-changelog
FelonEkonom
force-pushed
the
fix-tests-elixir-1.15
branch
from
12c8923
to
b1d7cc0
Compare
FelonEkonom
force-pushed
the
fix-tests-elixir-1.15
branch
from
ae56963
to
9aa180a
Compare
FelonEkonom
force-pushed
the
fix-tests-elixir-1.15
branch
from
9993cdc
to
142d765
Compare
mat-hek
reviewed
Sep 1, 2023
lib/membrane/logger.ex
Outdated
Comment on lines
46
to
47
| message.() | ||
| |> message_result_mapper.() |
There was a problem hiding this comment.
Because of credo error caused by dept = 3. This is a workaround to avoid it. I was not convinced to create a separate public function especially for this single usage
There was a problem hiding this comment.
So I'd disable this warning locally (or increase dept to 3 globally?) or find another way to write this
mat-hek
approved these changes
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Jira ticket: https://membraneframework.atlassian.net/browse/MC-226