Fix timer running late #685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varsill
added
the
no-changelog
mat-hek
requested changes
Nov 28, 2023
| @@ -256,7 +256,10 @@ defmodule Membrane.Core.Element do | |||
| end | |||
|
|
|||
| defp do_handle_info(Message.new(:timer_tick, timer_id), state) do | |||
| state = %{state | supplying_demand?: true} | |||
There was a problem hiding this comment.
Let's add a comment explaining why we do this
mat-hek
approved these changes
Nov 28, 2023
FelonEkonom
added a commit
that referenced
this pull request
Jan 23, 2024
This reverts commit 168f57e.
FelonEkonom
added a commit
that referenced
this pull request
Feb 26, 2024
…le_spec_started. (#708) * wip * Write tests wip * Write tests wip * Revert "Fix timer running late (#685)" This reverts commit 168f57e. * Fix actions handling order bug related to Pipeline.handle_playing * Add assertion on value passed with :setup action * WIP Fix bug in executing handle_buffer while handling actions from previous callback * Fix tests wip * Fix CI * Update changelog * Stopt calling handle_spec_started in between handling actions * Make demands test more strict * Add dots to changelog * Fix double tick bug * wip * Deprecate handle_spec_started/3 * Remove unused aliases * Remove unnecessary warning * Bump version to 1.0.1 * Remove leftovers * Fix docs * Implement suggestions from CR, bump version to 1.1.0-rc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
TimerController.handle_tickwith supplying_demand? flag