Update demand type to allow for the default demand size syntax #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mat-hek
added
the
no-changelog
mat-hek
reviewed
Mar 5, 2024
lib/membrane/element/action.ex
Outdated
| @@ -82,11 +82,12 @@ defmodule Membrane.Element.Action do | |||
| guaranteed not to receive more data than demanded. | |||
|
|
|||
| Demand size can be either a non-negative integer, that overrides existing demand, | |||
| or a function that is passed current demand, and is to return the new demand. | |||
| or a function that is passed current demand, and is to return the new demand. In case only pad | |||
| is specified, the demand size defaults to a value of 1. | |||
There was a problem hiding this comment.
Suggested change
| is specified, the demand size defaults to a value of 1. | |
| is specified, the demand size defaults to 1. |
FelonEkonom
approved these changes
Mar 8, 2024
mat-hek
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.