Fix the plugin #19
Merged
Fix the plugin #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varsill
requested changes
Jun 27, 2024
varsill
reviewed
Jun 28, 2024
| @@ -114,7 +112,7 @@ defmodule Membrane.IVF.SerializerTest do | |||
|
|
|||
| @tag :tmp_dir | |||
| test "serialize real vp9 buffers", %{tmp_dir: tmp_dir} do | |||
| buffers = File.read!(Path.join(@fixtures_dir, "capture.dump")) |> :erlang.binary_to_term() | |||
| buffers = Path.join(@fixtures_dir, "capture.dump") |> File.read!() |> :erlang.binary_to_term() | |||
There was a problem hiding this comment.
I cannot comment on line 132 of that file, but there are yet another places where such a change with piping would be welcome ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.