Reverted fuse update #162
Annotations
144 warnings
very complex type used. Consider factoring parts into `type` definitions:
cloudflow-node/src/main.rs#L84
warning: very complex type used. Consider factoring parts into `type` definitions
--> cloudflow-node/src/main.rs:84:6
|
84 | ) -> Result<(Option<&str>, Option<u32>, Option<u32>, bool, log::Level)> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
= note: `#[warn(clippy::type_complexity)]` on by default
|
very complex type used. Consider factoring parts into `type` definitions:
cloudflow-node/src/main.rs#L84
warning: very complex type used. Consider factoring parts into `type` definitions
--> cloudflow-node/src/main.rs:84:6
|
84 | ) -> Result<(Option<&str>, Option<u32>, Option<u32>, bool, log::Level)> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
= note: `#[warn(clippy::type_complexity)]` on by default
|
empty `loop {}` wastes CPU cycles:
cloudflow-node/src/main.rs#L43
warning: empty `loop {}` wastes CPU cycles
--> cloudflow-node/src/main.rs:43:5
|
43 | loop {}
| ^^^^^^^
|
= help: you should either use `panic!()` or add `std::thread::sleep(..);` to the loop body
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_loop
= note: `#[warn(clippy::empty_loop)]` on by default
|
empty `loop {}` wastes CPU cycles:
cloudflow-node/src/main.rs#L43
warning: empty `loop {}` wastes CPU cycles
--> cloudflow-node/src/main.rs:43:5
|
43 | loop {}
| ^^^^^^^
|
= help: you should either use `panic!()` or add `std::thread::sleep(..);` to the loop body
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_loop
= note: `#[warn(clippy::empty_loop)]` on by default
|
casting to the same type is unnecessary (`u64` -> `u64`):
cloudflow-minidump/src/lib.rs#L38
warning: casting to the same type is unnecessary (`u64` -> `u64`)
--> cloudflow-minidump/src/lib.rs:38:32
|
38 | base_of_image: i.base.to_umem() as u64,
| ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i.base.to_umem()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
= note: `#[warn(clippy::unnecessary_cast)]` on by default
|
casting to the same type is unnecessary (`u64` -> `u64`):
cloudflow-minidump/src/lib.rs#L38
warning: casting to the same type is unnecessary (`u64` -> `u64`)
--> cloudflow-minidump/src/lib.rs:38:32
|
38 | base_of_image: i.base.to_umem() as u64,
| ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i.base.to_umem()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
= note: `#[warn(clippy::unnecessary_cast)]` on by default
|
single-character string constant used as pattern:
cloudflow/src/util.rs#L28
warning: single-character string constant used as pattern
--> cloudflow/src/util.rs:28:41
|
28 | let (name, args) = input.split_once(":").unwrap_or((input, ""));
| ^^^ help: try using a `char` instead: `':'`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
|
single-character string constant used as pattern:
cloudflow/src/util.rs#L21
warning: single-character string constant used as pattern
--> cloudflow/src/util.rs:21:25
|
21 | .split_once(" ")
| ^^^ help: try using a `char` instead: `' '`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
|
useless use of `format!`:
cloudflow/src/process.rs#L502
warning: useless use of `format!`
--> cloudflow/src/process.rs:502:55
|
502 | out.call(BranchListEntry::new(format!("{}", name).into(), entry))
| ^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `name.to_string()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
|
single-character string constant used as pattern:
cloudflow/src/util.rs#L28
warning: single-character string constant used as pattern
--> cloudflow/src/util.rs:28:41
|
28 | let (name, args) = input.split_once(":").unwrap_or((input, ""));
| ^^^ help: try using a `char` instead: `':'`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
|
single-character string constant used as pattern:
cloudflow/src/util.rs#L21
warning: single-character string constant used as pattern
--> cloudflow/src/util.rs:21:25
|
21 | .split_once(" ")
| ^^^ help: try using a `char` instead: `' '`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
|
useless use of `format!`:
cloudflow/src/process.rs#L502
warning: useless use of `format!`
--> cloudflow/src/process.rs:502:55
|
502 | out.call(BranchListEntry::new(format!("{}", name).into(), entry))
| ^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `name.to_string()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
|
struct update has no effect, all the fields in the struct have already been specified:
cloudflow/src/process.rs#L330
warning: struct update has no effect, all the fields in the struct have already been specified
--> cloudflow/src/process.rs:330:15
|
330 | ..Default::default()
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update
|
struct update has no effect, all the fields in the struct have already been specified:
cloudflow/src/process.rs#L330
warning: struct update has no effect, all the fields in the struct have already been specified
--> cloudflow/src/process.rs:330:15
|
330 | ..Default::default()
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update
|
use of `format!` to build up a string from an iterator:
cloudflow/src/process.rs#L228
warning: use of `format!` to build up a string from an iterator
--> cloudflow/src/process.rs:228:23
|
228 | let out = maps
| _______________________^
229 | | .into_iter()
230 | | .map(|tr| {
231 | | let module = modules
... |
245 | | })
246 | | .collect::<String>();
| |____________________________________^
|
help: call `fold` instead
--> cloudflow/src/process.rs:230:18
|
230 | .map(|tr| {
| ^^^
help: ... and use the `write!` macro here
--> cloudflow/src/process.rs:237:21
|
237 | / format!(
238 | | "{:x}-{:x} {} {:9x} {}\n",
239 | | tr.in_virtual,
240 | | tr.in_virtual + tr.size,
... |
243 | | module.map(|m| m.name.as_ref()).unwrap_or_default()
244 | | )
| |_____________________^
= note: this can be written more efficiently by appending to a `String` directly
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_collect
|
use of `format!` to build up a string from an iterator:
cloudflow/src/process.rs#L186
warning: use of `format!` to build up a string from an iterator
--> cloudflow/src/process.rs:186:19
|
186 | let out = maps
| ___________________^
187 | | .into_iter()
188 | | .map(|CTup3(vaddr, size, page_type)| {
189 | | let module = modules
... |
202 | | })
203 | | .collect::<String>();
| |________________________________^
|
help: call `fold` instead
--> cloudflow/src/process.rs:188:14
|
188 | .map(|CTup3(vaddr, size, page_type)| {
| ^^^
help: ... and use the `write!` macro here
--> cloudflow/src/process.rs:195:17
|
195 | / format!(
196 | | "{:x}-{:x} {} {}\n",
197 | | vaddr,
198 | | vaddr + size,
199 | | perms,
200 | | module.map(|m| m.name.as_ref()).unwrap_or_default()
201 | | )
| |_________________^
= note: this can be written more efficiently by appending to a `String` directly
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_collect
= note: `#[warn(clippy::format_collect)]` on by default
|
use of `format!` to build up a string from an iterator:
cloudflow/src/process.rs#L228
warning: use of `format!` to build up a string from an iterator
--> cloudflow/src/process.rs:228:23
|
228 | let out = maps
| _______________________^
229 | | .into_iter()
230 | | .map(|tr| {
231 | | let module = modules
... |
245 | | })
246 | | .collect::<String>();
| |____________________________________^
|
help: call `fold` instead
--> cloudflow/src/process.rs:230:18
|
230 | .map(|tr| {
| ^^^
help: ... and use the `write!` macro here
--> cloudflow/src/process.rs:237:21
|
237 | / format!(
238 | | "{:x}-{:x} {} {:9x} {}\n",
239 | | tr.in_virtual,
240 | | tr.in_virtual + tr.size,
... |
243 | | module.map(|m| m.name.as_ref()).unwrap_or_default()
244 | | )
| |_____________________^
= note: this can be written more efficiently by appending to a `String` directly
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_collect
|
use of `format!` to build up a string from an iterator:
cloudflow/src/process.rs#L186
warning: use of `format!` to build up a string from an iterator
--> cloudflow/src/process.rs:186:19
|
186 | let out = maps
| ___________________^
187 | | .into_iter()
188 | | .map(|CTup3(vaddr, size, page_type)| {
189 | | let module = modules
... |
202 | | })
203 | | .collect::<String>();
| |________________________________^
|
help: call `fold` instead
--> cloudflow/src/process.rs:188:14
|
188 | .map(|CTup3(vaddr, size, page_type)| {
| ^^^
help: ... and use the `write!` macro here
--> cloudflow/src/process.rs:195:17
|
195 | / format!(
196 | | "{:x}-{:x} {} {}\n",
197 | | vaddr,
198 | | vaddr + size,
199 | | perms,
200 | | module.map(|m| m.name.as_ref()).unwrap_or_default()
201 | | )
| |_________________^
= note: this can be written more efficiently by appending to a `String` directly
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_collect
= note: `#[warn(clippy::format_collect)]` on by default
|
struct update has no effect, all the fields in the struct have already been specified:
cloudflow/src/process.rs#L77
warning: struct update has no effect, all the fields in the struct have already been specified
--> cloudflow/src/process.rs:77:15
|
77 | ..Default::default()
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update
|
struct update has no effect, all the fields in the struct have already been specified:
cloudflow/src/process.rs#L77
warning: struct update has no effect, all the fields in the struct have already been specified
--> cloudflow/src/process.rs:77:15
|
77 | ..Default::default()
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update
|
deref which would be done by auto-deref:
cloudflow/src/os.rs#L505
warning: deref which would be done by auto-deref
--> cloudflow/src/os.rs:505:39
|
505 | let name2: &str = &*i.name;
| ^^^^^^^^ help: try: `&i.name`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
= note: `#[warn(clippy::explicit_auto_deref)]` on by default
|
redundant closure:
cloudflow/src/os.rs#L499
warning: redundant closure
--> cloudflow/src/os.rs:499:18
|
499 | info.map(|i| Ok(i)).unwrap_or_else(|| {
| ^^^^^^^^^ help: replace the closure with the function itself: `Ok`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
|
deref which would be done by auto-deref:
cloudflow/src/os.rs#L505
warning: deref which would be done by auto-deref
--> cloudflow/src/os.rs:505:39
|
505 | let name2: &str = &*i.name;
| ^^^^^^^^ help: try: `&i.name`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
= note: `#[warn(clippy::explicit_auto_deref)]` on by default
|
single-character string constant used as pattern:
cloudflow/src/os.rs#L479
warning: single-character string constant used as pattern
--> cloudflow/src/os.rs:479:42
|
479 | .and_then(|p| p.strip_suffix(")"))
| ^^^ help: try using a `char` instead: `')'`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
|
redundant closure:
cloudflow/src/os.rs#L499
warning: redundant closure
--> cloudflow/src/os.rs:499:18
|
499 | info.map(|i| Ok(i)).unwrap_or_else(|| {
| ^^^^^^^^^ help: replace the closure with the function itself: `Ok`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
|
single-character string constant used as pattern:
cloudflow/src/os.rs#L478
warning: single-character string constant used as pattern
--> cloudflow/src/os.rs:478:27
|
478 | .strip_prefix("(")
| ^^^ help: try using a `char` instead: `'('`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
|
single-character string constant used as pattern:
cloudflow/src/os.rs#L476
warning: single-character string constant used as pattern
--> cloudflow/src/os.rs:476:44
|
476 | let (name, pid) = name.rsplit_once(" ").ok_or(ErrorKind::InvalidArgument)?;
| ^^^ help: try using a `char` instead: `' '`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
= note: `#[warn(clippy::single_char_pattern)]` on by default
|
single-character string constant used as pattern:
cloudflow/src/os.rs#L479
warning: single-character string constant used as pattern
--> cloudflow/src/os.rs:479:42
|
479 | .and_then(|p| p.strip_suffix(")"))
| ^^^ help: try using a `char` instead: `')'`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
|
single-character string constant used as pattern:
cloudflow/src/os.rs#L478
warning: single-character string constant used as pattern
--> cloudflow/src/os.rs:478:27
|
478 | .strip_prefix("(")
| ^^^ help: try using a `char` instead: `'('`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
|
single-character string constant used as pattern:
cloudflow/src/os.rs#L476
warning: single-character string constant used as pattern
--> cloudflow/src/os.rs:476:44
|
476 | let (name, pid) = name.rsplit_once(" ").ok_or(ErrorKind::InvalidArgument)?;
| ^^^ help: try using a `char` instead: `' '`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
= note: `#[warn(clippy::single_char_pattern)]` on by default
|
useless use of `format!`:
cloudflow/src/os.rs#L446
warning: useless use of `format!`
--> cloudflow/src/os.rs:446:55
|
446 | out.call(BranchListEntry::new(format!("{}", name).into(), entry))
| ^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `name.to_string()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
= note: `#[warn(clippy::useless_format)]` on by default
|
useless use of `format!`:
cloudflow/src/os.rs#L446
warning: useless use of `format!`
--> cloudflow/src/os.rs:446:55
|
446 | out.call(BranchListEntry::new(format!("{}", name).into(), entry))
| ^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `name.to_string()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
= note: `#[warn(clippy::useless_format)]` on by default
|
redundant closure:
cloudflow/src/os.rs#L404
warning: redundant closure
--> cloudflow/src/os.rs:404:18
|
404 | info.map(|i| Ok(i)).unwrap_or_else(|| {
| ^^^^^^^^^ help: replace the closure with the function itself: `Ok`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
|
redundant closure:
cloudflow/src/os.rs#L404
warning: redundant closure
--> cloudflow/src/os.rs:404:18
|
404 | info.map(|i| Ok(i)).unwrap_or_else(|| {
| ^^^^^^^^^ help: replace the closure with the function itself: `Ok`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
|
redundant closure:
cloudflow/src/os.rs#L314
warning: redundant closure
--> cloudflow/src/os.rs:314:18
|
314 | info.map(|i| Ok(i)).unwrap_or_else(|| {
| ^^^^^^^^^ help: replace the closure with the function itself: `Ok`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
= note: `#[warn(clippy::redundant_closure)]` on by default
|
redundant closure:
cloudflow/src/os.rs#L314
warning: redundant closure
--> cloudflow/src/os.rs:314:18
|
314 | info.map(|i| Ok(i)).unwrap_or_else(|| {
| ^^^^^^^^^ help: replace the closure with the function itself: `Ok`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
= note: `#[warn(clippy::redundant_closure)]` on by default
|
useless conversion to the same type: `os::ThreadedOsArc`:
cloudflow/src/os.rs#L146
warning: useless conversion to the same type: `os::ThreadedOsArc`
--> cloudflow/src/os.rs:146:21
|
146 | os: c.into(),
| ^^^^^^^^ help: consider removing `.into()`: `c`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `#[warn(clippy::useless_conversion)]` on by default
|
useless conversion to the same type: `os::ThreadedOsArc`:
cloudflow/src/os.rs#L146
warning: useless conversion to the same type: `os::ThreadedOsArc`
--> cloudflow/src/os.rs:146:21
|
146 | os: c.into(),
| ^^^^^^^^ help: consider removing `.into()`: `c`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `#[warn(clippy::useless_conversion)]` on by default
|
struct update has no effect, all the fields in the struct have already been specified:
cloudflow/src/os.rs#L114
warning: struct update has no effect, all the fields in the struct have already been specified
--> cloudflow/src/os.rs:114:15
|
114 | ..Default::default()
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update
|
struct update has no effect, all the fields in the struct have already been specified:
cloudflow/src/os.rs#L114
warning: struct update has no effect, all the fields in the struct have already been specified
--> cloudflow/src/os.rs:114:15
|
114 | ..Default::default()
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update
|
struct update has no effect, all the fields in the struct have already been specified:
cloudflow/src/module.rs#L55
warning: struct update has no effect, all the fields in the struct have already been specified
--> cloudflow/src/module.rs:55:15
|
55 | ..Default::default()
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update
|
struct update has no effect, all the fields in the struct have already been specified:
cloudflow/src/module.rs#L55
warning: struct update has no effect, all the fields in the struct have already been specified
--> cloudflow/src/module.rs:55:15
|
55 | ..Default::default()
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update
|
struct update has no effect, all the fields in the struct have already been specified:
cloudflow/src/connector.rs#L60
warning: struct update has no effect, all the fields in the struct have already been specified
--> cloudflow/src/connector.rs:60:15
|
60 | ..Default::default()
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update
= note: `#[warn(clippy::needless_update)]` on by default
|
struct update has no effect, all the fields in the struct have already been specified:
cloudflow/src/connector.rs#L60
warning: struct update has no effect, all the fields in the struct have already been specified
--> cloudflow/src/connector.rs:60:15
|
60 | ..Default::default()
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update
= note: `#[warn(clippy::needless_update)]` on by default
|
deref which would be done by auto-deref:
filer/src/thread_ctx.rs#L180
warning: deref which would be done by auto-deref
--> filer/src/thread_ctx.rs:180:29
|
180 | if (self.stack_pop)(&*self.stack, &mut out) {
| ^^^^^^^^^^^^ help: try: `&self.stack`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
|
deref which would be done by auto-deref:
filer/src/thread_ctx.rs#L175
warning: deref which would be done by auto-deref
--> filer/src/thread_ctx.rs:175:27
|
175 | (self.stack_push)(&*self.stack, val.into())
| ^^^^^^^^^^^^ help: try: `&self.stack`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
|
unsafe function's docs miss `# Safety` section:
filer/src/plugin_store.rs#L220
warning: unsafe function's docs miss `# Safety` section
--> filer/src/plugin_store.rs:220:5
|
220 | / pub unsafe fn register_mapping_raw(
221 | | &self,
222 | | id: UTypeId,
223 | | layout: &'static TypeLayout,
224 | | name: &str,
225 | | mapping: OpaqueMapping,
226 | | ) -> bool {
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc
|
unsafe function's docs miss `# Safety` section:
filer/src/plugin_store.rs#L187
warning: unsafe function's docs miss `# Safety` section
--> filer/src/plugin_store.rs:187:5
|
187 | / pub unsafe fn entries_raw(
188 | | &self,
189 | | id: UTypeId,
190 | | layout: &'static TypeLayout,
191 | | ) -> Entry<DashMap<String, OpaqueMapping>> {
| |______________________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc
= note: `#[warn(clippy::missing_safety_doc)]` on by default
|
deref which would be done by auto-deref:
filer/src/plugin_store.rs#L177
warning: deref which would be done by auto-deref
--> filer/src/plugin_store.rs:177:17
|
177 | &*self.store,
| ^^^^^^^^^^^^ help: try: `&self.store`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
|
deref which would be done by auto-deref:
filer/src/plugin_store.rs#L153
warning: deref which would be done by auto-deref
--> filer/src/plugin_store.rs:153:17
|
153 | &*self.store,
| ^^^^^^^^^^^^ help: try: `&self.store`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
|
deref which would be done by auto-deref:
filer/src/plugin_store.rs#L141
warning: deref which would be done by auto-deref
--> filer/src/plugin_store.rs:141:17
|
141 | &*self.store,
| ^^^^^^^^^^^^ help: try: `&self.store`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
= note: `#[warn(clippy::explicit_auto_deref)]` on by default
|
casting to the same type is unnecessary (`u64` -> `u64`):
filer/src/node.rs#L511
warning: casting to the same type is unnecessary (`u64` -> `u64`)
--> filer/src/node.rs:511:20
|
511 | Ok(self.1 .0 as u64)
| ^^^^^^^^^^^^^^^^ help: try: `self.1 .0`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
casting to the same type is unnecessary (`u64` -> `u64`):
filer/src/node.rs#L502
warning: casting to the same type is unnecessary (`u64` -> `u64`)
--> filer/src/node.rs:502:29
|
502 | self.1 .0 = v as u64;
| ^^^^^^^^ help: try: `v`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
= note: `#[warn(clippy::unnecessary_cast)]` on by default
|
the following explicit lifetimes could be elided: 'a:
filer/src/fs.rs#L176
warning: the following explicit lifetimes could be elided: 'a
--> filer/src/fs.rs:176:24
|
176 | extern "C" fn read<'a>(&self, mut data: VecOps<RWData<'a>>) -> i32 {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
|
176 - extern "C" fn read<'a>(&self, mut data: VecOps<RWData<'a>>) -> i32 {
176 + extern "C" fn read(&self, mut data: VecOps<RWData<'_>>) -> i32 {
|
|
very complex type used. Consider factoring parts into `type` definitions:
filer/src/backend.rs#L97
warning: very complex type used. Consider factoring parts into `type` definitions
--> filer/src/backend.rs:97:15
|
97 | build_fn: Option<fn(&str, &CArc<C>) -> Result<T>>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
= note: `#[warn(clippy::type_complexity)]` on by default
|
field `mount_point` is never read:
filer-fuse/src/lib.rs#L13
warning: field `mount_point` is never read
--> filer-fuse/src/lib.rs:13:5
|
11 | pub struct FilerFs {
| ------- field in this struct
12 | node: CArcSome<Node>,
13 | mount_point: String,
| ^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
field `mount_point` is never read:
filer-fuse/src/lib.rs#L13
warning: field `mount_point` is never read
--> filer-fuse/src/lib.rs:13:5
|
11 | pub struct FilerFs {
| ------- field in this struct
12 | node: CArcSome<Node>,
13 | mount_point: String,
| ^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
deref which would be done by auto-deref:
filer/src/thread_ctx.rs#L180
warning: deref which would be done by auto-deref
--> filer/src/thread_ctx.rs:180:29
|
180 | if (self.stack_pop)(&*self.stack, &mut out) {
| ^^^^^^^^^^^^ help: try: `&self.stack`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
|
deref which would be done by auto-deref:
filer/src/thread_ctx.rs#L175
warning: deref which would be done by auto-deref
--> filer/src/thread_ctx.rs:175:27
|
175 | (self.stack_push)(&*self.stack, val.into())
| ^^^^^^^^^^^^ help: try: `&self.stack`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
|
unsafe function's docs miss `# Safety` section:
filer/src/plugin_store.rs#L220
warning: unsafe function's docs miss `# Safety` section
--> filer/src/plugin_store.rs:220:5
|
220 | / pub unsafe fn register_mapping_raw(
221 | | &self,
222 | | id: UTypeId,
223 | | layout: &'static TypeLayout,
224 | | name: &str,
225 | | mapping: OpaqueMapping,
226 | | ) -> bool {
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc
|
unsafe function's docs miss `# Safety` section:
filer/src/plugin_store.rs#L187
warning: unsafe function's docs miss `# Safety` section
--> filer/src/plugin_store.rs:187:5
|
187 | / pub unsafe fn entries_raw(
188 | | &self,
189 | | id: UTypeId,
190 | | layout: &'static TypeLayout,
191 | | ) -> Entry<DashMap<String, OpaqueMapping>> {
| |______________________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc
= note: `#[warn(clippy::missing_safety_doc)]` on by default
|
deref which would be done by auto-deref:
filer/src/plugin_store.rs#L177
warning: deref which would be done by auto-deref
--> filer/src/plugin_store.rs:177:17
|
177 | &*self.store,
| ^^^^^^^^^^^^ help: try: `&self.store`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
|
deref which would be done by auto-deref:
filer/src/plugin_store.rs#L153
warning: deref which would be done by auto-deref
--> filer/src/plugin_store.rs:153:17
|
153 | &*self.store,
| ^^^^^^^^^^^^ help: try: `&self.store`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
|
deref which would be done by auto-deref:
filer/src/plugin_store.rs#L141
warning: deref which would be done by auto-deref
--> filer/src/plugin_store.rs:141:17
|
141 | &*self.store,
| ^^^^^^^^^^^^ help: try: `&self.store`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
= note: `#[warn(clippy::explicit_auto_deref)]` on by default
|
casting to the same type is unnecessary (`u64` -> `u64`):
filer/src/node.rs#L511
warning: casting to the same type is unnecessary (`u64` -> `u64`)
--> filer/src/node.rs:511:20
|
511 | Ok(self.1 .0 as u64)
| ^^^^^^^^^^^^^^^^ help: try: `self.1 .0`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
casting to the same type is unnecessary (`u64` -> `u64`):
filer/src/node.rs#L502
warning: casting to the same type is unnecessary (`u64` -> `u64`)
--> filer/src/node.rs:502:29
|
502 | self.1 .0 = v as u64;
| ^^^^^^^^ help: try: `v`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
= note: `#[warn(clippy::unnecessary_cast)]` on by default
|
the following explicit lifetimes could be elided: 'a:
filer/src/fs.rs#L176
warning: the following explicit lifetimes could be elided: 'a
--> filer/src/fs.rs:176:24
|
176 | extern "C" fn read<'a>(&self, mut data: VecOps<RWData<'a>>) -> i32 {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
|
176 - extern "C" fn read<'a>(&self, mut data: VecOps<RWData<'a>>) -> i32 {
176 + extern "C" fn read(&self, mut data: VecOps<RWData<'_>>) -> i32 {
|
|
very complex type used. Consider factoring parts into `type` definitions:
filer/src/backend.rs#L97
warning: very complex type used. Consider factoring parts into `type` definitions
--> filer/src/backend.rs:97:15
|
97 | build_fn: Option<fn(&str, &CArc<C>) -> Result<T>>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
= note: `#[warn(clippy::type_complexity)]` on by default
|
build
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
very complex type used. Consider factoring parts into `type` definitions:
cloudflow-node/src/main.rs#L84
warning: very complex type used. Consider factoring parts into `type` definitions
--> cloudflow-node/src/main.rs:84:6
|
84 | ) -> Result<(Option<&str>, Option<u32>, Option<u32>, bool, log::Level)> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
= note: `#[warn(clippy::type_complexity)]` on by default
|
very complex type used. Consider factoring parts into `type` definitions:
cloudflow-node/src/main.rs#L84
warning: very complex type used. Consider factoring parts into `type` definitions
--> cloudflow-node/src/main.rs:84:6
|
84 | ) -> Result<(Option<&str>, Option<u32>, Option<u32>, bool, log::Level)> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
= note: `#[warn(clippy::type_complexity)]` on by default
|
empty `loop {}` wastes CPU cycles:
cloudflow-node/src/main.rs#L43
warning: empty `loop {}` wastes CPU cycles
--> cloudflow-node/src/main.rs:43:5
|
43 | loop {}
| ^^^^^^^
|
= help: you should either use `panic!()` or add `std::thread::sleep(..);` to the loop body
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_loop
= note: `#[warn(clippy::empty_loop)]` on by default
|
empty `loop {}` wastes CPU cycles:
cloudflow-node/src/main.rs#L43
warning: empty `loop {}` wastes CPU cycles
--> cloudflow-node/src/main.rs:43:5
|
43 | loop {}
| ^^^^^^^
|
= help: you should either use `panic!()` or add `std::thread::sleep(..);` to the loop body
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_loop
= note: `#[warn(clippy::empty_loop)]` on by default
|
casting to the same type is unnecessary (`u64` -> `u64`):
cloudflow-minidump/src/lib.rs#L38
warning: casting to the same type is unnecessary (`u64` -> `u64`)
--> cloudflow-minidump/src/lib.rs:38:32
|
38 | base_of_image: i.base.to_umem() as u64,
| ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i.base.to_umem()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
= note: `#[warn(clippy::unnecessary_cast)]` on by default
|
casting to the same type is unnecessary (`u64` -> `u64`):
cloudflow-minidump/src/lib.rs#L38
warning: casting to the same type is unnecessary (`u64` -> `u64`)
--> cloudflow-minidump/src/lib.rs:38:32
|
38 | base_of_image: i.base.to_umem() as u64,
| ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i.base.to_umem()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
= note: `#[warn(clippy::unnecessary_cast)]` on by default
|
single-character string constant used as pattern:
cloudflow/src/util.rs#L28
warning: single-character string constant used as pattern
--> cloudflow/src/util.rs:28:41
|
28 | let (name, args) = input.split_once(":").unwrap_or((input, ""));
| ^^^ help: try using a `char` instead: `':'`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
|
single-character string constant used as pattern:
cloudflow/src/util.rs#L21
warning: single-character string constant used as pattern
--> cloudflow/src/util.rs:21:25
|
21 | .split_once(" ")
| ^^^ help: try using a `char` instead: `' '`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
|
useless use of `format!`:
cloudflow/src/process.rs#L502
warning: useless use of `format!`
--> cloudflow/src/process.rs:502:55
|
502 | out.call(BranchListEntry::new(format!("{}", name).into(), entry))
| ^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `name.to_string()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
|
struct update has no effect, all the fields in the struct have already been specified:
cloudflow/src/process.rs#L330
warning: struct update has no effect, all the fields in the struct have already been specified
--> cloudflow/src/process.rs:330:15
|
330 | ..Default::default()
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update
|
single-character string constant used as pattern:
cloudflow/src/util.rs#L28
warning: single-character string constant used as pattern
--> cloudflow/src/util.rs:28:41
|
28 | let (name, args) = input.split_once(":").unwrap_or((input, ""));
| ^^^ help: try using a `char` instead: `':'`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
|
single-character string constant used as pattern:
cloudflow/src/util.rs#L21
warning: single-character string constant used as pattern
--> cloudflow/src/util.rs:21:25
|
21 | .split_once(" ")
| ^^^ help: try using a `char` instead: `' '`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
|
useless use of `format!`:
cloudflow/src/process.rs#L502
warning: useless use of `format!`
--> cloudflow/src/process.rs:502:55
|
502 | out.call(BranchListEntry::new(format!("{}", name).into(), entry))
| ^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `name.to_string()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
|
use of `format!` to build up a string from an iterator:
cloudflow/src/process.rs#L228
warning: use of `format!` to build up a string from an iterator
--> cloudflow/src/process.rs:228:23
|
228 | let out = maps
| _______________________^
229 | | .into_iter()
230 | | .map(|tr| {
231 | | let module = modules
... |
245 | | })
246 | | .collect::<String>();
| |____________________________________^
|
help: call `fold` instead
--> cloudflow/src/process.rs:230:18
|
230 | .map(|tr| {
| ^^^
help: ... and use the `write!` macro here
--> cloudflow/src/process.rs:237:21
|
237 | / format!(
238 | | "{:x}-{:x} {} {:9x} {}\n",
239 | | tr.in_virtual,
240 | | tr.in_virtual + tr.size,
... |
243 | | module.map(|m| m.name.as_ref()).unwrap_or_default()
244 | | )
| |_____________________^
= note: this can be written more efficiently by appending to a `String` directly
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_collect
|
use of `format!` to build up a string from an iterator:
cloudflow/src/process.rs#L186
warning: use of `format!` to build up a string from an iterator
--> cloudflow/src/process.rs:186:19
|
186 | let out = maps
| ___________________^
187 | | .into_iter()
188 | | .map(|CTup3(vaddr, size, page_type)| {
189 | | let module = modules
... |
202 | | })
203 | | .collect::<String>();
| |________________________________^
|
help: call `fold` instead
--> cloudflow/src/process.rs:188:14
|
188 | .map(|CTup3(vaddr, size, page_type)| {
| ^^^
help: ... and use the `write!` macro here
--> cloudflow/src/process.rs:195:17
|
195 | / format!(
196 | | "{:x}-{:x} {} {}\n",
197 | | vaddr,
198 | | vaddr + size,
199 | | perms,
200 | | module.map(|m| m.name.as_ref()).unwrap_or_default()
201 | | )
| |_________________^
= note: this can be written more efficiently by appending to a `String` directly
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_collect
= note: `#[warn(clippy::format_collect)]` on by default
|
struct update has no effect, all the fields in the struct have already been specified:
cloudflow/src/process.rs#L330
warning: struct update has no effect, all the fields in the struct have already been specified
--> cloudflow/src/process.rs:330:15
|
330 | ..Default::default()
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update
|
use of `format!` to build up a string from an iterator:
cloudflow/src/process.rs#L228
warning: use of `format!` to build up a string from an iterator
--> cloudflow/src/process.rs:228:23
|
228 | let out = maps
| _______________________^
229 | | .into_iter()
230 | | .map(|tr| {
231 | | let module = modules
... |
245 | | })
246 | | .collect::<String>();
| |____________________________________^
|
help: call `fold` instead
--> cloudflow/src/process.rs:230:18
|
230 | .map(|tr| {
| ^^^
help: ... and use the `write!` macro here
--> cloudflow/src/process.rs:237:21
|
237 | / format!(
238 | | "{:x}-{:x} {} {:9x} {}\n",
239 | | tr.in_virtual,
240 | | tr.in_virtual + tr.size,
... |
243 | | module.map(|m| m.name.as_ref()).unwrap_or_default()
244 | | )
| |_____________________^
= note: this can be written more efficiently by appending to a `String` directly
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_collect
|
use of `format!` to build up a string from an iterator:
cloudflow/src/process.rs#L186
warning: use of `format!` to build up a string from an iterator
--> cloudflow/src/process.rs:186:19
|
186 | let out = maps
| ___________________^
187 | | .into_iter()
188 | | .map(|CTup3(vaddr, size, page_type)| {
189 | | let module = modules
... |
202 | | })
203 | | .collect::<String>();
| |________________________________^
|
help: call `fold` instead
--> cloudflow/src/process.rs:188:14
|
188 | .map(|CTup3(vaddr, size, page_type)| {
| ^^^
help: ... and use the `write!` macro here
--> cloudflow/src/process.rs:195:17
|
195 | / format!(
196 | | "{:x}-{:x} {} {}\n",
197 | | vaddr,
198 | | vaddr + size,
199 | | perms,
200 | | module.map(|m| m.name.as_ref()).unwrap_or_default()
201 | | )
| |_________________^
= note: this can be written more efficiently by appending to a `String` directly
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_collect
= note: `#[warn(clippy::format_collect)]` on by default
|
struct update has no effect, all the fields in the struct have already been specified:
cloudflow/src/process.rs#L77
warning: struct update has no effect, all the fields in the struct have already been specified
--> cloudflow/src/process.rs:77:15
|
77 | ..Default::default()
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update
|
struct update has no effect, all the fields in the struct have already been specified:
cloudflow/src/process.rs#L77
warning: struct update has no effect, all the fields in the struct have already been specified
--> cloudflow/src/process.rs:77:15
|
77 | ..Default::default()
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update
|
deref which would be done by auto-deref:
cloudflow/src/os.rs#L505
warning: deref which would be done by auto-deref
--> cloudflow/src/os.rs:505:39
|
505 | let name2: &str = &*i.name;
| ^^^^^^^^ help: try: `&i.name`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
= note: `#[warn(clippy::explicit_auto_deref)]` on by default
|
redundant closure:
cloudflow/src/os.rs#L499
warning: redundant closure
--> cloudflow/src/os.rs:499:18
|
499 | info.map(|i| Ok(i)).unwrap_or_else(|| {
| ^^^^^^^^^ help: replace the closure with the function itself: `Ok`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
|
single-character string constant used as pattern:
cloudflow/src/os.rs#L479
warning: single-character string constant used as pattern
--> cloudflow/src/os.rs:479:42
|
479 | .and_then(|p| p.strip_suffix(")"))
| ^^^ help: try using a `char` instead: `')'`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
|
single-character string constant used as pattern:
cloudflow/src/os.rs#L478
warning: single-character string constant used as pattern
--> cloudflow/src/os.rs:478:27
|
478 | .strip_prefix("(")
| ^^^ help: try using a `char` instead: `'('`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
|
single-character string constant used as pattern:
cloudflow/src/os.rs#L476
warning: single-character string constant used as pattern
--> cloudflow/src/os.rs:476:44
|
476 | let (name, pid) = name.rsplit_once(" ").ok_or(ErrorKind::InvalidArgument)?;
| ^^^ help: try using a `char` instead: `' '`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
= note: `#[warn(clippy::single_char_pattern)]` on by default
|
useless use of `format!`:
cloudflow/src/os.rs#L446
warning: useless use of `format!`
--> cloudflow/src/os.rs:446:55
|
446 | out.call(BranchListEntry::new(format!("{}", name).into(), entry))
| ^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `name.to_string()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
= note: `#[warn(clippy::useless_format)]` on by default
|
deref which would be done by auto-deref:
cloudflow/src/os.rs#L505
warning: deref which would be done by auto-deref
--> cloudflow/src/os.rs:505:39
|
505 | let name2: &str = &*i.name;
| ^^^^^^^^ help: try: `&i.name`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
= note: `#[warn(clippy::explicit_auto_deref)]` on by default
|
redundant closure:
cloudflow/src/os.rs#L499
warning: redundant closure
--> cloudflow/src/os.rs:499:18
|
499 | info.map(|i| Ok(i)).unwrap_or_else(|| {
| ^^^^^^^^^ help: replace the closure with the function itself: `Ok`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
|
single-character string constant used as pattern:
cloudflow/src/os.rs#L479
warning: single-character string constant used as pattern
--> cloudflow/src/os.rs:479:42
|
479 | .and_then(|p| p.strip_suffix(")"))
| ^^^ help: try using a `char` instead: `')'`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
|
single-character string constant used as pattern:
cloudflow/src/os.rs#L478
warning: single-character string constant used as pattern
--> cloudflow/src/os.rs:478:27
|
478 | .strip_prefix("(")
| ^^^ help: try using a `char` instead: `'('`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
|
single-character string constant used as pattern:
cloudflow/src/os.rs#L476
warning: single-character string constant used as pattern
--> cloudflow/src/os.rs:476:44
|
476 | let (name, pid) = name.rsplit_once(" ").ok_or(ErrorKind::InvalidArgument)?;
| ^^^ help: try using a `char` instead: `' '`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
= note: `#[warn(clippy::single_char_pattern)]` on by default
|
redundant closure:
cloudflow/src/os.rs#L404
warning: redundant closure
--> cloudflow/src/os.rs:404:18
|
404 | info.map(|i| Ok(i)).unwrap_or_else(|| {
| ^^^^^^^^^ help: replace the closure with the function itself: `Ok`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
|
useless use of `format!`:
cloudflow/src/os.rs#L446
warning: useless use of `format!`
--> cloudflow/src/os.rs:446:55
|
446 | out.call(BranchListEntry::new(format!("{}", name).into(), entry))
| ^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `name.to_string()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
= note: `#[warn(clippy::useless_format)]` on by default
|
redundant closure:
cloudflow/src/os.rs#L404
warning: redundant closure
--> cloudflow/src/os.rs:404:18
|
404 | info.map(|i| Ok(i)).unwrap_or_else(|| {
| ^^^^^^^^^ help: replace the closure with the function itself: `Ok`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
|
redundant closure:
cloudflow/src/os.rs#L314
warning: redundant closure
--> cloudflow/src/os.rs:314:18
|
314 | info.map(|i| Ok(i)).unwrap_or_else(|| {
| ^^^^^^^^^ help: replace the closure with the function itself: `Ok`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
= note: `#[warn(clippy::redundant_closure)]` on by default
|
redundant closure:
cloudflow/src/os.rs#L314
warning: redundant closure
--> cloudflow/src/os.rs:314:18
|
314 | info.map(|i| Ok(i)).unwrap_or_else(|| {
| ^^^^^^^^^ help: replace the closure with the function itself: `Ok`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
= note: `#[warn(clippy::redundant_closure)]` on by default
|
useless conversion to the same type: `os::ThreadedOsArc`:
cloudflow/src/os.rs#L146
warning: useless conversion to the same type: `os::ThreadedOsArc`
--> cloudflow/src/os.rs:146:21
|
146 | os: c.into(),
| ^^^^^^^^ help: consider removing `.into()`: `c`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `#[warn(clippy::useless_conversion)]` on by default
|
useless conversion to the same type: `os::ThreadedOsArc`:
cloudflow/src/os.rs#L146
warning: useless conversion to the same type: `os::ThreadedOsArc`
--> cloudflow/src/os.rs:146:21
|
146 | os: c.into(),
| ^^^^^^^^ help: consider removing `.into()`: `c`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `#[warn(clippy::useless_conversion)]` on by default
|
struct update has no effect, all the fields in the struct have already been specified:
cloudflow/src/os.rs#L114
warning: struct update has no effect, all the fields in the struct have already been specified
--> cloudflow/src/os.rs:114:15
|
114 | ..Default::default()
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update
|
struct update has no effect, all the fields in the struct have already been specified:
cloudflow/src/os.rs#L114
warning: struct update has no effect, all the fields in the struct have already been specified
--> cloudflow/src/os.rs:114:15
|
114 | ..Default::default()
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update
|
struct update has no effect, all the fields in the struct have already been specified:
cloudflow/src/module.rs#L55
warning: struct update has no effect, all the fields in the struct have already been specified
--> cloudflow/src/module.rs:55:15
|
55 | ..Default::default()
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update
|
struct update has no effect, all the fields in the struct have already been specified:
cloudflow/src/module.rs#L55
warning: struct update has no effect, all the fields in the struct have already been specified
--> cloudflow/src/module.rs:55:15
|
55 | ..Default::default()
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update
|
struct update has no effect, all the fields in the struct have already been specified:
cloudflow/src/connector.rs#L60
warning: struct update has no effect, all the fields in the struct have already been specified
--> cloudflow/src/connector.rs:60:15
|
60 | ..Default::default()
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update
= note: `#[warn(clippy::needless_update)]` on by default
|
struct update has no effect, all the fields in the struct have already been specified:
cloudflow/src/connector.rs#L60
warning: struct update has no effect, all the fields in the struct have already been specified
--> cloudflow/src/connector.rs:60:15
|
60 | ..Default::default()
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update
= note: `#[warn(clippy::needless_update)]` on by default
|
deref which would be done by auto-deref:
filer/src/thread_ctx.rs#L180
warning: deref which would be done by auto-deref
--> filer/src/thread_ctx.rs:180:29
|
180 | if (self.stack_pop)(&*self.stack, &mut out) {
| ^^^^^^^^^^^^ help: try: `&self.stack`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
|
deref which would be done by auto-deref:
filer/src/thread_ctx.rs#L175
warning: deref which would be done by auto-deref
--> filer/src/thread_ctx.rs:175:27
|
175 | (self.stack_push)(&*self.stack, val.into())
| ^^^^^^^^^^^^ help: try: `&self.stack`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
|
unsafe function's docs miss `# Safety` section:
filer/src/plugin_store.rs#L220
warning: unsafe function's docs miss `# Safety` section
--> filer/src/plugin_store.rs:220:5
|
220 | / pub unsafe fn register_mapping_raw(
221 | | &self,
222 | | id: UTypeId,
223 | | layout: &'static TypeLayout,
224 | | name: &str,
225 | | mapping: OpaqueMapping,
226 | | ) -> bool {
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc
|
unsafe function's docs miss `# Safety` section:
filer/src/plugin_store.rs#L187
warning: unsafe function's docs miss `# Safety` section
--> filer/src/plugin_store.rs:187:5
|
187 | / pub unsafe fn entries_raw(
188 | | &self,
189 | | id: UTypeId,
190 | | layout: &'static TypeLayout,
191 | | ) -> Entry<DashMap<String, OpaqueMapping>> {
| |______________________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc
= note: `#[warn(clippy::missing_safety_doc)]` on by default
|
deref which would be done by auto-deref:
filer/src/plugin_store.rs#L177
warning: deref which would be done by auto-deref
--> filer/src/plugin_store.rs:177:17
|
177 | &*self.store,
| ^^^^^^^^^^^^ help: try: `&self.store`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
|
deref which would be done by auto-deref:
filer/src/plugin_store.rs#L153
warning: deref which would be done by auto-deref
--> filer/src/plugin_store.rs:153:17
|
153 | &*self.store,
| ^^^^^^^^^^^^ help: try: `&self.store`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
|
deref which would be done by auto-deref:
filer/src/plugin_store.rs#L141
warning: deref which would be done by auto-deref
--> filer/src/plugin_store.rs:141:17
|
141 | &*self.store,
| ^^^^^^^^^^^^ help: try: `&self.store`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
= note: `#[warn(clippy::explicit_auto_deref)]` on by default
|
casting to the same type is unnecessary (`u64` -> `u64`):
filer/src/node.rs#L511
warning: casting to the same type is unnecessary (`u64` -> `u64`)
--> filer/src/node.rs:511:20
|
511 | Ok(self.1 .0 as u64)
| ^^^^^^^^^^^^^^^^ help: try: `self.1 .0`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
casting to the same type is unnecessary (`u64` -> `u64`):
filer/src/node.rs#L502
warning: casting to the same type is unnecessary (`u64` -> `u64`)
--> filer/src/node.rs:502:29
|
502 | self.1 .0 = v as u64;
| ^^^^^^^^ help: try: `v`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
= note: `#[warn(clippy::unnecessary_cast)]` on by default
|
the following explicit lifetimes could be elided: 'a:
filer/src/fs.rs#L176
warning: the following explicit lifetimes could be elided: 'a
--> filer/src/fs.rs:176:24
|
176 | extern "C" fn read<'a>(&self, mut data: VecOps<RWData<'a>>) -> i32 {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
|
176 - extern "C" fn read<'a>(&self, mut data: VecOps<RWData<'a>>) -> i32 {
176 + extern "C" fn read(&self, mut data: VecOps<RWData<'_>>) -> i32 {
|
|
very complex type used. Consider factoring parts into `type` definitions:
filer/src/backend.rs#L97
warning: very complex type used. Consider factoring parts into `type` definitions
--> filer/src/backend.rs:97:15
|
97 | build_fn: Option<fn(&str, &CArc<C>) -> Result<T>>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
= note: `#[warn(clippy::type_complexity)]` on by default
|
field `mount_point` is never read:
filer-fuse/src/lib.rs#L13
warning: field `mount_point` is never read
--> filer-fuse/src/lib.rs:13:5
|
11 | pub struct FilerFs {
| ------- field in this struct
12 | node: CArcSome<Node>,
13 | mount_point: String,
| ^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
field `mount_point` is never read:
filer-fuse/src/lib.rs#L13
warning: field `mount_point` is never read
--> filer-fuse/src/lib.rs:13:5
|
11 | pub struct FilerFs {
| ------- field in this struct
12 | node: CArcSome<Node>,
13 | mount_point: String,
| ^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
deref which would be done by auto-deref:
filer/src/thread_ctx.rs#L180
warning: deref which would be done by auto-deref
--> filer/src/thread_ctx.rs:180:29
|
180 | if (self.stack_pop)(&*self.stack, &mut out) {
| ^^^^^^^^^^^^ help: try: `&self.stack`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
|
deref which would be done by auto-deref:
filer/src/thread_ctx.rs#L175
warning: deref which would be done by auto-deref
--> filer/src/thread_ctx.rs:175:27
|
175 | (self.stack_push)(&*self.stack, val.into())
| ^^^^^^^^^^^^ help: try: `&self.stack`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
|
unsafe function's docs miss `# Safety` section:
filer/src/plugin_store.rs#L220
warning: unsafe function's docs miss `# Safety` section
--> filer/src/plugin_store.rs:220:5
|
220 | / pub unsafe fn register_mapping_raw(
221 | | &self,
222 | | id: UTypeId,
223 | | layout: &'static TypeLayout,
224 | | name: &str,
225 | | mapping: OpaqueMapping,
226 | | ) -> bool {
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc
|
unsafe function's docs miss `# Safety` section:
filer/src/plugin_store.rs#L187
warning: unsafe function's docs miss `# Safety` section
--> filer/src/plugin_store.rs:187:5
|
187 | / pub unsafe fn entries_raw(
188 | | &self,
189 | | id: UTypeId,
190 | | layout: &'static TypeLayout,
191 | | ) -> Entry<DashMap<String, OpaqueMapping>> {
| |______________________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc
= note: `#[warn(clippy::missing_safety_doc)]` on by default
|
deref which would be done by auto-deref:
filer/src/plugin_store.rs#L177
warning: deref which would be done by auto-deref
--> filer/src/plugin_store.rs:177:17
|
177 | &*self.store,
| ^^^^^^^^^^^^ help: try: `&self.store`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
|
deref which would be done by auto-deref:
filer/src/plugin_store.rs#L153
warning: deref which would be done by auto-deref
--> filer/src/plugin_store.rs:153:17
|
153 | &*self.store,
| ^^^^^^^^^^^^ help: try: `&self.store`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
|
deref which would be done by auto-deref:
filer/src/plugin_store.rs#L141
warning: deref which would be done by auto-deref
--> filer/src/plugin_store.rs:141:17
|
141 | &*self.store,
| ^^^^^^^^^^^^ help: try: `&self.store`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
= note: `#[warn(clippy::explicit_auto_deref)]` on by default
|
casting to the same type is unnecessary (`u64` -> `u64`):
filer/src/node.rs#L511
warning: casting to the same type is unnecessary (`u64` -> `u64`)
--> filer/src/node.rs:511:20
|
511 | Ok(self.1 .0 as u64)
| ^^^^^^^^^^^^^^^^ help: try: `self.1 .0`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
casting to the same type is unnecessary (`u64` -> `u64`):
filer/src/node.rs#L502
warning: casting to the same type is unnecessary (`u64` -> `u64`)
--> filer/src/node.rs:502:29
|
502 | self.1 .0 = v as u64;
| ^^^^^^^^ help: try: `v`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
= note: `#[warn(clippy::unnecessary_cast)]` on by default
|
the following explicit lifetimes could be elided: 'a:
filer/src/fs.rs#L176
warning: the following explicit lifetimes could be elided: 'a
--> filer/src/fs.rs:176:24
|
176 | extern "C" fn read<'a>(&self, mut data: VecOps<RWData<'a>>) -> i32 {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
|
176 - extern "C" fn read<'a>(&self, mut data: VecOps<RWData<'a>>) -> i32 {
176 + extern "C" fn read(&self, mut data: VecOps<RWData<'_>>) -> i32 {
|
|
very complex type used. Consider factoring parts into `type` definitions:
filer/src/backend.rs#L97
warning: very complex type used. Consider factoring parts into `type` definitions
--> filer/src/backend.rs:97:15
|
97 | build_fn: Option<fn(&str, &CArc<C>) -> Result<T>>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
= note: `#[warn(clippy::type_complexity)]` on by default
|
lint
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
test
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
build-coverage
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
build-coverage
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
build-coverage
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
build-coverage
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
build-coverage
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|