Skip to content
Build and test

Updated minidump-writer so the latest rust version will compile it ag… #161

Sign in to view logs

Updated minidump-writer so the latest rust version will compile it ag…

Updated minidump-writer so the latest rust version will compile it ag… #161

GitHub Actions / clippy failed Dec 15, 2023 in 1s

clippy

22 errors, 24 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 22
Warning 24
Note 0
Help 0

Versions

  • rustc 1.74.1 (a28077b28 2023-12-04)
  • cargo 1.74.1 (ecb9851af 2023-10-18)
  • clippy 0.1.74 (a28077b 2023-12-04)

Annotations

Check warning on line 180 in filer/src/thread_ctx.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

deref which would be done by auto-deref 

warning: deref which would be done by auto-deref
   --> filer/src/thread_ctx.rs:180:29
    |
180 |         if (self.stack_pop)(&*self.stack, &mut out) {
    |                             ^^^^^^^^^^^^ help: try: `&self.stack`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref

Check warning on line 175 in filer/src/thread_ctx.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

deref which would be done by auto-deref 

warning: deref which would be done by auto-deref
   --> filer/src/thread_ctx.rs:175:27
    |
175 |         (self.stack_push)(&*self.stack, val.into())
    |                           ^^^^^^^^^^^^ help: try: `&self.stack`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref

Check warning on line 226 in filer/src/plugin_store.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unsafe function's docs miss `# Safety` section 

warning: unsafe function's docs miss `# Safety` section
   --> filer/src/plugin_store.rs:220:5
    |
220 | /     pub unsafe fn register_mapping_raw(
221 | |         &self,
222 | |         id: UTypeId,
223 | |         layout: &'static TypeLayout,
224 | |         name: &str,
225 | |         mapping: OpaqueMapping,
226 | |     ) -> bool {
    | |_____________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc

Check warning on line 191 in filer/src/plugin_store.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unsafe function's docs miss `# Safety` section 

warning: unsafe function's docs miss `# Safety` section
   --> filer/src/plugin_store.rs:187:5
    |
187 | /     pub unsafe fn entries_raw(
188 | |         &self,
189 | |         id: UTypeId,
190 | |         layout: &'static TypeLayout,
191 | |     ) -> Entry<DashMap<String, OpaqueMapping>> {
    | |______________________________________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc
    = note: `#[warn(clippy::missing_safety_doc)]` on by default

Check warning on line 177 in filer/src/plugin_store.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

deref which would be done by auto-deref 

warning: deref which would be done by auto-deref
   --> filer/src/plugin_store.rs:177:17
    |
177 |                 &*self.store,
    |                 ^^^^^^^^^^^^ help: try: `&self.store`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref

Check warning on line 153 in filer/src/plugin_store.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

deref which would be done by auto-deref 

warning: deref which would be done by auto-deref
   --> filer/src/plugin_store.rs:153:17
    |
153 |                 &*self.store,
    |                 ^^^^^^^^^^^^ help: try: `&self.store`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref

Check warning on line 141 in filer/src/plugin_store.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

deref which would be done by auto-deref 

warning: deref which would be done by auto-deref
   --> filer/src/plugin_store.rs:141:17
    |
141 |                 &*self.store,
    |                 ^^^^^^^^^^^^ help: try: `&self.store`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
    = note: `#[warn(clippy::explicit_auto_deref)]` on by default

Check warning on line 511 in filer/src/node.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

casting to the same type is unnecessary (`u64` -> `u64`) 

warning: casting to the same type is unnecessary (`u64` -> `u64`)
   --> filer/src/node.rs:511:20
    |
511 |                 Ok(self.1 .0 as u64)
    |                    ^^^^^^^^^^^^^^^^ help: try: `self.1 .0`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast

Check warning on line 502 in filer/src/node.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

casting to the same type is unnecessary (`u64` -> `u64`) 

warning: casting to the same type is unnecessary (`u64` -> `u64`)
   --> filer/src/node.rs:502:29
    |
502 |                 self.1 .0 = v as u64;
    |                             ^^^^^^^^ help: try: `v`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
    = note: `#[warn(clippy::unnecessary_cast)]` on by default

Check warning on line 176 in filer/src/fs.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'a 

warning: the following explicit lifetimes could be elided: 'a
   --> filer/src/fs.rs:176:24
    |
176 |     extern "C" fn read<'a>(&self, mut data: VecOps<RWData<'a>>) -> i32 {
    |                        ^^                                 ^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
    = note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
    |
176 -     extern "C" fn read<'a>(&self, mut data: VecOps<RWData<'a>>) -> i32 {
176 +     extern "C" fn read(&self, mut data: VecOps<RWData<'_>>) -> i32 {
    |

Check warning on line 97 in filer/src/backend.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

very complex type used. Consider factoring parts into `type` definitions 

warning: very complex type used. Consider factoring parts into `type` definitions
  --> filer/src/backend.rs:97:15
   |
97 |     build_fn: Option<fn(&str, &CArc<C>) -> Result<T>>,
   |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
   = note: `#[warn(clippy::type_complexity)]` on by default

Check failure on line 81 in filer-fuse/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

failed to resolve: use of undeclared type `Timespec` 

error[E0433]: failed to resolve: use of undeclared type `Timespec`
  --> filer-fuse/src/lib.rs:81:33
   |
81 |                         crtime: Timespec::new(0, 0),
   |                                 ^^^^^^^^ use of undeclared type `Timespec`

Check failure on line 81 in filer-fuse/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

failed to resolve: use of undeclared type `Timespec` 

error[E0433]: failed to resolve: use of undeclared type `Timespec`
  --> filer-fuse/src/lib.rs:81:33
   |
81 |                         crtime: Timespec::new(0, 0),
   |                                 ^^^^^^^^ use of undeclared type `Timespec`

Check failure on line 40 in filer-fuse/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

method `destroy` has 2 parameters but the declaration in trait `fuse_mt::FilesystemMT::destroy` has 1 

error[E0050]: method `destroy` has 2 parameters but the declaration in trait `fuse_mt::FilesystemMT::destroy` has 1
  --> filer-fuse/src/lib.rs:40:16
   |
40 |     fn destroy(&self, _req: RequestInfo) {
   |                ^^^^^^^^^^^^^^^^^^^^^^^^ expected 1 parameter, found 2
   |
   = note: `destroy` from trait: `fn(&Self)`

Check failure on line 40 in filer-fuse/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

method `destroy` has 2 parameters but the declaration in trait `fuse_mt::FilesystemMT::destroy` has 1 

error[E0050]: method `destroy` has 2 parameters but the declaration in trait `fuse_mt::FilesystemMT::destroy` has 1
  --> filer-fuse/src/lib.rs:40:16
   |
40 |     fn destroy(&self, _req: RequestInfo) {
   |                ^^^^^^^^^^^^^^^^^^^^^^^^ expected 1 parameter, found 2
   |
   = note: `destroy` from trait: `fn(&Self)`

Check warning on line 9 in filer-fuse/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `time::*` 

warning: unused import: `time::*`
 --> filer-fuse/src/lib.rs:9:5
  |
9 | use time::*;
  |     ^^^^^^^
  |
  = note: `#[warn(unused_imports)]` on by default

Check failure on line 637 in filer-fuse/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

`Result` is ambiguous 

error[E0659]: `Result` is ambiguous
   --> filer-fuse/src/lib.rs:637:6
    |
637 | ) -> Result<()> {
    |      ^^^^^^ ambiguous name
    |
    = note: ambiguous because of multiple glob imports of a name in the same module
note: `Result` could refer to the type alias imported here
   --> filer-fuse/src/lib.rs:1:5
    |
1   | use filer::prelude::v1::*;
    |     ^^^^^^^^^^^^^^^^^^^^^
    = help: consider adding an explicit import of `Result` to disambiguate
note: `Result` could also refer to the type alias imported here
   --> filer-fuse/src/lib.rs:9:5
    |
9   | use time::*;
    |     ^^^^^^^
    = help: consider adding an explicit import of `Result` to disambiguate

Check failure on line 170 in filer-fuse/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

cannot find type `Timespec` in this scope 

error[E0412]: cannot find type `Timespec` in this scope
   --> filer-fuse/src/lib.rs:170:27
    |
170 |         _bkuptime: Option<Timespec>,
    |                           ^^^^^^^^ not found in this scope
    |
help: you might be missing a type parameter
    |
33  | impl<Timespec> FilesystemMT for FilerFs {
    |     ++++++++++

Check failure on line 169 in filer-fuse/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

cannot find type `Timespec` in this scope 

error[E0412]: cannot find type `Timespec` in this scope
   --> filer-fuse/src/lib.rs:169:26
    |
169 |         _chgtime: Option<Timespec>,
    |                          ^^^^^^^^ not found in this scope
    |
help: you might be missing a type parameter
    |
33  | impl<Timespec> FilesystemMT for FilerFs {
    |     ++++++++++

Check failure on line 168 in filer-fuse/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

cannot find type `Timespec` in this scope 

error[E0412]: cannot find type `Timespec` in this scope
   --> filer-fuse/src/lib.rs:168:25
    |
168 |         _crtime: Option<Timespec>,
    |                         ^^^^^^^^ not found in this scope
    |
help: you might be missing a type parameter
    |
33  | impl<Timespec> FilesystemMT for FilerFs {
    |     ++++++++++

Check failure on line 155 in filer-fuse/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

cannot find type `Timespec` in this scope 

error[E0412]: cannot find type `Timespec` in this scope
   --> filer-fuse/src/lib.rs:155:24
    |
155 |         _mtime: Option<Timespec>,
    |                        ^^^^^^^^ not found in this scope
    |
help: you might be missing a type parameter
    |
33  | impl<Timespec> FilesystemMT for FilerFs {
    |     ++++++++++

Check failure on line 154 in filer-fuse/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

cannot find type `Timespec` in this scope 

error[E0412]: cannot find type `Timespec` in this scope
   --> filer-fuse/src/lib.rs:154:24
    |
154 |         _atime: Option<Timespec>,
    |                        ^^^^^^^^ not found in this scope
    |
help: you might be missing a type parameter
    |
33  | impl<Timespec> FilesystemMT for FilerFs {
    |     ++++++++++

Check failure on line 71 in filer-fuse/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

cannot find function `get_time` in crate `time` 

error[E0425]: cannot find function `get_time` in crate `time`
  --> filer-fuse/src/lib.rs:71:33
   |
71 |                 let now = time::get_time();
   |                                 ^^^^^^^^ not found in `time`

Check failure on line 19 in filer-fuse/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

cannot find struct, variant or union type `Timespec` in this scope 

error[E0422]: cannot find struct, variant or union type `Timespec` in this scope
  --> filer-fuse/src/lib.rs:19:23
   |
19 | const TTL: Timespec = Timespec { sec: 1, nsec: 0 };
   |                       ^^^^^^^^ not found in this scope

Check failure on line 19 in filer-fuse/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

cannot find type `Timespec` in this scope 

error[E0412]: cannot find type `Timespec` in this scope
  --> filer-fuse/src/lib.rs:19:12
   |
19 | const TTL: Timespec = Timespec { sec: 1, nsec: 0 };
   |            ^^^^^^^^ not found in this scope
View more details on GitHub Actions