Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memgraph vs. Adya weak consistency #807

Merged
merged 7 commits into from
Jun 14, 2024
Merged

Memgraph vs. Adya weak consistency #807

merged 7 commits into from
Jun 14, 2024

Conversation

as51340
Copy link
Contributor

@as51340 as51340 commented May 29, 2024 •
edited
Loading

Description

  • Added which phenomena are disabled by our isolation levels.
  • Added Adya isolation levels supported by Memgraph

Pull request type

Please check what kind of PR this is:

  • Fix or improvement of an existing page
  • New documentation page, release related

Related PRs and issues

PR this doc page is related to:
memgraph/memgraph#2086

Closes:
(paste the link to the issue it closes)

Checklist:

  • Check all content with Grammarly
  • Perform a self-review of my code
  • Make corresponding changes to the rest of the documentation (consult with the DX team)
  • The build passes locally
  • My changes generate no new warnings or errors
  • Add a corresponding label
  • If release-related, add a product and version label
  • If release-related, add release note on product PR

@vercel Vercel
Copy link

vercel bot commented May 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 14, 2024 2:01pm

@as51340 as51340 self-assigned this May 29, 2024
@as51340 as51340 changed the base branch from main to memgraph-2-18 May 29, 2024 11:42
@as51340 as51340 force-pushed the adya-isolation-levels branch from adaa6ba to 2563e7d Compare May 29, 2024 11:43
@as51340 as51340 mentioned this pull request Jun 5, 2024
Merged
7 tasks
@as51340 as51340 force-pushed the adya-isolation-levels branch from ffef5d1 to 0ca5a69 Compare June 5, 2024 06:02
@as51340 as51340 marked this pull request as ready for review June 5, 2024 06:02
@as51340 as51340 requested a review from kgolubic as a code owner June 5, 2024 06:03
@as51340 as51340 added the status: ready PR is ready for review label Jun 5, 2024
@as51340
Copy link
Contributor Author

as51340 commented Jun 5, 2024

@kgolubic This can be merged before release, Memgraph's PR doesn't change anything except tests

@kgolubic kgolubic requested a review from hal-eisen-MG June 10, 2024 08:19
hal-eisen-MG
hal-eisen-MG previously approved these changes Jun 14, 2024
View reviewed changes
Copy link
Contributor

@hal-eisen-MG hal-eisen-MG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgolubic kgolubic changed the base branch from memgraph-2-18 to main June 14, 2024 13:57
@kgolubic kgolubic dismissed hal-eisen-MG’s stale review June 14, 2024 13:57

The base branch was changed.

kgolubic
kgolubic approved these changes Jun 14, 2024
View reviewed changes
Copy link
Contributor

@kgolubic kgolubic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks OK.

@kgolubic kgolubic merged commit ecd03c4 into main Jun 14, 2024
2 checks passed
@kgolubic kgolubic deleted the adya-isolation-levels branch June 14, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgolubic kgolubic kgolubic approved these changes

@hal-eisen-MG hal-eisen-MG hal-eisen-MG left review comments

Assignees

@as51340 as51340

Labels
status: ready PR is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@as51340 @kgolubic @hal-eisen-MG