-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make large dependencies optional #235
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antepusic
added
type: enhancement
New feature or request
status: draft
PR is in draft phase
labels
Apr 4, 2023
antepusic
added
status: ready
PR is ready for review
and removed
status: draft
PR is in draft phase
labels
Apr 5, 2023
7 tasks
This was
linked to
issues
Apr 5, 2023
antepusic
added
type: bug
Something isn't working
and removed
type: enhancement
New feature or request
labels
Apr 5, 2023
Josipmrden
requested changes
Apr 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs will also need to be updated
antepusic
added
status: ready
PR is ready for review
and removed
status: change
PR reviewed - needs changes
labels
Apr 17, 2023
Josipmrden
reviewed
Apr 18, 2023
Josipmrden
approved these changes
Apr 18, 2023
brunos252
suggested changes
Apr 18, 2023
katarinasupe
approved these changes
Apr 18, 2023
brunos252
approved these changes
Apr 18, 2023
katarinasupe
added
status: ship it
PR approved
and removed
status: ready
PR is ready for review
labels
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In order to make installing GQLAlchemy easier, this PR makes large dependencies (pyarrow, dgl and torch) optional:
pip install gqlalchemy
← skips the dependenciespip install gqlalchemy[arrow]
← installs pyarrow:dgl and torch are grouped because dgl-specific features also use torch for data structures:
pip install gqlalchemy[dgl]
← installs dgl and torchAlternatively, users who wish to install PyG manually can install just torch:
pip install gqlalchemy[torch_pyg]
← installs torchThe
all
extra covers all above dependencies:pip install gqlalchemy[all]
← installs everythingPull request type
Please delete options that are not relevant.
Related issues
Closes #178 #226 #227 #230
Checklist:
######################################
Reviewer checklist (the reviewer checks this part)
######################################