Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make large dependencies optional #235

Merged
merged 27 commits into from
Apr 18, 2023
Merged

Conversation

antepusic
Copy link
Contributor

@antepusic antepusic commented Apr 4, 2023

Description

In order to make installing GQLAlchemy easier, this PR makes large dependencies (pyarrow, dgl and torch) optional:

pip install gqlalchemy ← skips the dependencies

pip install gqlalchemy[arrow] ← installs pyarrow:

dgl and torch are grouped because dgl-specific features also use torch for data structures:

  • pip install gqlalchemy[dgl]← installs dgl and torch

Alternatively, users who wish to install PyG manually can install just torch:

  • pip install gqlalchemy[torch_pyg]← installs torch

The all extra covers all above dependencies:

pip install gqlalchemy[all] ← installs everything

Pull request type

Please delete options that are not relevant.

  • Build or packaging related changes

Related issues

Closes #178 #226 #227 #230

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation (docs#813)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

######################################

Reviewer checklist (the reviewer checks this part)

  • Core feature implementation
  • Tests
  • Code documentation
  • Documentation on memgraph/docs

######################################

@antepusic antepusic added type: enhancement New feature or request status: draft PR is in draft phase labels Apr 4, 2023
@antepusic antepusic added this to the v1.5.0 milestone Apr 4, 2023
@antepusic antepusic self-assigned this Apr 4, 2023
@Josipmrden Josipmrden modified the milestones: v1.5.0, v1.4.1 Apr 5, 2023
@antepusic antepusic added status: ready PR is ready for review and removed status: draft PR is in draft phase labels Apr 5, 2023
@antepusic antepusic marked this pull request as draft April 5, 2023 16:57
@antepusic antepusic marked this pull request as ready for review April 5, 2023 16:57
@antepusic antepusic added type: bug Something isn't working and removed type: enhancement New feature or request labels Apr 5, 2023
Copy link
Contributor

@Josipmrden Josipmrden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs will also need to be updated

pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
@antepusic antepusic requested a review from katarinasupe April 17, 2023 00:10
@antepusic antepusic marked this pull request as draft April 17, 2023 08:31
@antepusic antepusic added status: ready PR is ready for review and removed status: change PR reviewed - needs changes labels Apr 17, 2023
@antepusic antepusic marked this pull request as ready for review April 17, 2023 08:32
@Josipmrden Josipmrden self-requested a review April 18, 2023 10:40
pyproject.toml Show resolved Hide resolved
gqlalchemy/transformations/translators/pyg_translator.py Outdated Show resolved Hide resolved
gqlalchemy/utilities.py Outdated Show resolved Hide resolved
@katarinasupe katarinasupe merged commit 367f2ca into main Apr 18, 2023
@katarinasupe katarinasupe added status: ship it PR approved and removed status: ready PR is ready for review labels Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ship it PR approved type: bug Something isn't working
Projects
Status: Done
4 participants