Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master < T] Pydantic v2 #278

Merged
merged 10 commits into from
Sep 21, 2023
Merged

[master < T] Pydantic v2 #278

merged 10 commits into from
Sep 21, 2023

Conversation

as51340
Copy link
Contributor

@as51340 as51340 commented Sep 20, 2023

Description

Bumped pydantic to v2.3.0

Pull request type

Please delete options that are not relevant.

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring with functional or API changes
  • Refactoring without functional or API changes
  • Build or packaging related changes
  • Documentation content changes
  • Other (please describe):

Related issues

Delete section if this PR doesn't resolve any issues.

Closes (link to issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

######################################

Reviewer checklist (the reviewer checks this part)

  • Core feature implementation
  • Tests
  • Code documentation
  • Documentation on gqlalchemy/docs

######################################

@as51340 as51340 self-assigned this Sep 20, 2023
@as51340 as51340 added this to the v1.5.0 milestone Sep 20, 2023
@antepusic antepusic linked an issue Sep 20, 2023 that may be closed by this pull request
Copy link
Contributor

@antepusic antepusic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this; I’ve linked this PR to the associated issue

@as51340
Copy link
Contributor Author

as51340 commented Sep 20, 2023

@antepusic it is still not working, problems with some type

@katarinasupe
Copy link
Contributor

katarinasupe commented Sep 20, 2023

@as51340 we should be careful with migration to Pydantic v2 and how that affects our users and us. This guide might help: https://docs.pydantic.dev/latest/migration/#migration-guide. The conclusion of this PR might also be us not moving to Pydantic v2 for now (if you conclude it's too much work for now). But, notice also what users suggested in the linked issue: #257 (comment) . I also found this in their migration guide that might help: https://docs.pydantic.dev/latest/migration/#continue-using-pydantic-v1-features

@katarinasupe
Copy link
Contributor

katarinasupe commented Sep 20, 2023

There is also a tool that might help if we migrate: https://docs.pydantic.dev/latest/migration/#code-transformation-tool

@as51340 as51340 added the status: ship it PR approved label Sep 21, 2023
@katarinasupe katarinasupe merged commit 4709478 into main Sep 21, 2023
5 checks passed
@antepusic antepusic deleted the update-pydantic-to-v2 branch September 21, 2023 14:35
@jpmmcneill jpmmcneill mentioned this pull request Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Upgrade to pydantic v2
3 participants