Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main < T279] Turn Docker into an optional dependency #279

Merged
merged 3 commits into from
Sep 21, 2023

Conversation

antepusic
Copy link
Contributor

@antepusic antepusic commented Sep 21, 2023

Description

This PR converts Docker from a dependency into an extra, on account of the docker package itself depending on the vulnerable pywin32 package.

Pull request type

  • Build or packaging related changes

Related issues

Closes #261

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

######################################

Reviewer checklist (the reviewer checks this part)

  • Core feature implementation
  • Tests
  • Code documentation
  • Documentation on gqlalchemy/docs

######################################

@antepusic antepusic added type: bug Something isn't working status: draft PR is in draft phase labels Sep 21, 2023
@antepusic antepusic added this to the v1.5.0 milestone Sep 21, 2023
@antepusic antepusic self-assigned this Sep 21, 2023
@antepusic antepusic marked this pull request as ready for review September 21, 2023 12:09
@katarinasupe
Copy link
Contributor

Looks okay. Update README and docs in new PR. I will generate new reference guide 😄

@katarinasupe katarinasupe added status: ship it PR approved and removed status: draft PR is in draft phase labels Sep 21, 2023
@katarinasupe katarinasupe merged commit d5c61f8 into main Sep 21, 2023
5 checks passed
@antepusic antepusic deleted the fix-docker-dependency branch September 21, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ship it PR approved type: bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[BUG] Inclusion of the docker dependency bring in pywin32 which has an outstanding vulnerability
3 participants