Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transactions queries #310

Merged
merged 7 commits into from
Jul 9, 2024
Merged

Add transactions queries #310

merged 7 commits into from
Jul 9, 2024

Conversation

katarinasupe
Copy link
Contributor

Description

I added get transactions and terminate transactions methods for easier transaction management.

Pull request type

  • Feature

Related issues

Closes #240

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation TODO generate reference guide
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

######################################

Reviewer checklist (the reviewer checks this part)

  • Core feature implementation
  • Tests
  • Code documentation
  • Documentation on gqlalchemy/docs

######################################

@katarinasupe katarinasupe added the type: enhancement New feature or request label Jun 24, 2024
Copy link
Contributor

@antepusic antepusic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is all right once you apply the below suggestion:

gqlalchemy/vendors/memgraph.py Outdated Show resolved Hide resolved
@antepusic antepusic added the status: change PR reviewed - needs changes label Jun 24, 2024
@antepusic
Copy link
Contributor

@katarinasupe Is this also milestone 1.6.0 like #309?

@katarinasupe katarinasupe added this to the v1.6.0 milestone Jun 24, 2024
@katarinasupe
Copy link
Contributor Author

@katarinasupe Is this also milestone 1.6.0 like #309?

Yes! Thank you, I updated it. I just need to deal with the tests first since I bumped up Memgraph in the workflow :D Then I'll incorporate your suggestions.

Copy link
Contributor

@as51340 as51340 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, few comments

tests/ogm/test_transactions.py Show resolved Hide resolved
gqlalchemy/vendors/memgraph.py Outdated Show resolved Hide resolved
gqlalchemy/vendors/memgraph.py Outdated Show resolved Hide resolved
@katarinasupe katarinasupe requested review from as51340 and antepusic July 4, 2024 13:22
Copy link
Contributor

@as51340 as51340 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small comment, otherwise good, I will approve. Delete unnecessary variable initialization

gqlalchemy/vendors/memgraph.py Outdated Show resolved Hide resolved
Copy link
Contributor

@antepusic antepusic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seconding Andi’s comment

@katarinasupe katarinasupe merged commit cb21b4a into main Jul 9, 2024
5 checks passed
@katarinasupe katarinasupe deleted the add-transactions-queries branch July 9, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: change PR reviewed - needs changes type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add transaction queries to query builder
3 participants