-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add transactions queries #310
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is all right once you apply the below suggestion:
@katarinasupe Is this also milestone 1.6.0 like #309? |
Yes! Thank you, I updated it. I just need to deal with the tests first since I bumped up Memgraph in the workflow :D Then I'll incorporate your suggestions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, few comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one small comment, otherwise good, I will approve. Delete unnecessary variable initialization
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seconding Andi’s comment
Description
I added get transactions and terminate transactions methods for easier transaction management.
Pull request type
Related issues
Closes #240
Checklist:
######################################
Reviewer checklist (the reviewer checks this part)
######################################