[develop < T0005-GA] Add execute option to query builder #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gqlalchemy/query_builder.py
Outdated
| @@ -372,28 +372,33 @@ class DeclarativeBase(ABC): | |||
| def __init__(self, connection: Optional[Union[Connection, Memgraph]] = None): | |||
| self._query: List[Any] = [] | |||
| self._connection = connection if connection is not None else Memgraph() | |||
| self._clauses: List[DeclarativeBaseTypes] = [] | |||
There was a problem hiding this comment.
Are we planning some extensive use of this list of clauses? It seems to me that as of now it is being read from only to check if there is "RETURN" statement. If we have some plans around this list, then ok, otherwise, i would replace it with simple boolean
Josipmrden
approved these changes
Mar 2, 2022
BorisTasevski
approved these changes
Mar 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RETURNclause was used in the query builder to callexecute()instead ofexecute_and_fetch()