Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix static number of volumes - fixes #11 #12

Merged
merged 7 commits into from
Apr 25, 2024

Conversation

hpdobrica
Copy link
Contributor

@hpdobrica hpdobrica commented Nov 17, 2023

Hello there, in order to enable running multiple replicas, each with their own storage, i have:

  • removed predefined persistent volume claims
  • added volumeClaimTemplates to the statefulset
  • ensured memgraph fullname is used both when creating and connecting the volumes

note that this is likely a breaking change which will require reinstall of the chart and migration of data (old single volume was named memgraph-lib-storage, new one would be memgraph-lib-storage-memgraph-$POD_NUMBER , as we are editing the volumeClaimTemplates field:

Error: UPGRADE FAILED: cannot patch "memgraph" with kind StatefulSet: StatefulSet.apps "memgraph" is invalid: spec: Forbidden: updates to statefulset spec for fields other than 'replicas', 'template', 'updateStrategy', 'persistentVolumeClaimRetentionPolicy' and 'minReadySeconds' are forbidden

i have also added the option to define a desired storage class to be used when creating the volumes.

this pr fixes #11

@katarinasupe
Copy link
Collaborator

Thank you, @hpdobrica, for your contribution! You're improving the Memgraph experience for our whole community 😄 We will review this PR as soon as possible and get back to you.

@katarinasupe katarinasupe added the enhancement New feature or request label Nov 17, 2023
@antejavor antejavor self-assigned this Apr 22, 2024
@antejavor antejavor added this to the v0.1.2 milestone Apr 22, 2024
Copy link
Collaborator

@antejavor antejavor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR includes updates to enable the increase of the replicate set value to more than 1.

It closes the following issue: #11

It also includes the updates to the README and closes #10.

The Memgraph version has been increased to the latest available 2.16.0

Thanks a lot for the initial push @hpdobrica 🦾 🥳

@antejavor antejavor merged commit 09dbecc into memgraph:main Apr 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: MemGraph Volume Error for replicas > 1
3 participants